-
Notifications
You must be signed in to change notification settings - Fork 7
test: test tailwind-v4 vite plugin #677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
hi-ogawa
wants to merge
14
commits into
main
Choose a base branch
from
test-tailwind-v4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi-ogawa
commented
Feb 8, 2025
hi-ogawa
commented
Feb 16, 2025
| @@ -0,0 +1,7 @@ | |||
| diff --git a/dist/index.mjs b/dist/index.mjs | |||
Owner
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since xxx.css and xxx.css?direct seem to also get in dead lock, we might need to add ?direct
- const SPECIAL_QUERY_RE = /[?&](?:worker|sharedworker|raw|url)\b/
+ const SPECIAL_QUERY_RE = /[?&](?:worker|sharedworker|raw|url|direct)\b/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo
notes
Our virtual css request is getting stuck http://localhost:5173/@id/__x00__virtual:dev-ssr-css.css?direct
This can be reproduced with curl:
It looks like this
transformRequestis stuck when/app/styles.css?directvite-plugins/packages/react-server/src/features/assets/css.ts
Line 17 in fbb6b82
It's likely a dead lock of
ViteDevServer.waitForRequestsIdleof multiple "css root files", which relies on the following heuristicsisPotentialCssRootFile. Probably there's something odd with having bothvirtual:dev-ssr-css.cssand/app/styles.css.https://github.com/tailwindlabs/tailwindcss/blob/d684733d804a0b8951d13c94fe27350271e076b6/packages/%40tailwindcss-vite/src/index.ts#L313-L322
Since
virtual:dev-ssr-css.cssis only to proxy styles from server to client, it is legitimate to skip it from tailwind processing since/app/styles.cssis the original one tailwind can process. Is there a way to let tailwind skip our virtual?