Skip to content

Add file logging for license requests and challenges#1

Open
hichchiputha wants to merge 2 commits into
mainfrom
feature/log-everything-12058571071587642015
Open

Add file logging for license requests and challenges#1
hichchiputha wants to merge 2 commits into
mainfrom
feature/log-everything-12058571071587642015

Conversation

@hichchiputha
Copy link
Copy Markdown
Owner

Implemented a logging system that records Widevine license exchange events to a documents/ folder. The logs include timestamps and hex-encoded binary data for requests and challenges.


PR created automatically by Jules for task 12058571071587642015 started by @hichchiputha

This commit implements a persistent logging system that records license
requests, challenges, responses, and loaded keys into timestamped text
files in a `documents/` folder.

Changes:
- Added `chrono` dependency for timestamp formatting.
- Created `src/logging.rs` for file-based logging.
- Initialized logging in `InitializeCdmModule_4`.
- Added logging calls in `Session::create` and `Session::update`.
- Added logging for session closure.

Co-authored-by: hichchiputha <168877723+hichchiputha@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

This update improves the logging system by:
- Using the system's actual Documents folder via the `dirs` crate.
- Creating an `OpenWV_Logs` subdirectory for better organization.
- Using `PathBuf` for more robust path handling.
- Reporting file I/O errors to the console (stderr) for debugging.
- Adding `OpenWV_Logs` to `.gitignore`.

Co-authored-by: hichchiputha <168877723+hichchiputha@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant