Better error handling for failure to connect to Redis server #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jahands
reviewed
Aug 3, 2023
| {:redis_error, data} -> | ||
| %{code: 400, message: Jason.encode!(data), json: true} | ||
|
|
||
| {:not_authorized, message} -> |
Contributor
There was a problem hiding this comment.
Would it make sense to encode other errors the same way? (Maybe in a separate PR?)
Edit: oops, was 2 minutes too late :)
Owner
Author
There was a problem hiding this comment.
Haha, yes, I can do another PR for error overhaul and clean this all up
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires a bit more code to ensure the pool gets properly destroyed, but now an error 500 is returned with the message "Unable to connect to the Redis server" when it is unable to establish a connection