Skip to content

Conversation

@hiett
Copy link
Owner

@hiett hiett commented Aug 3, 2023

Cases to test:

  • Missing bearer header, eventually hits a match for :malformed_data, so :not_found is never actually triggered (can remove if so) It was unused, but is now being used for actual 404 errors such as below
  • Handle additional 404s as JSON errors too, as could be due to future Upstash features using a new endpoint (such as when multi-exec was added)
  • Not including Content-Type json will cause a 500 to be thrown without an error message at all SRH code isn't even hit, this is happening by a missing Plug Parser

@hiett hiett linked an issue Aug 3, 2023 that may be closed by this pull request
@hiett hiett marked this pull request as ready for review August 3, 2023 02:58
@hiett hiett merged commit e8a4156 into master Aug 3, 2023
@hiett hiett deleted the 14-error-overhaul branch August 3, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error overhaul

2 participants