Skip to content

Conversation

@Vadman97
Copy link
Member

Replaying an app with invalid DOM nesting may crash rrweb.
Print console warning instead of crashing.

@linear
Copy link

linear bot commented May 11, 2022

HIG-2269 "Uncaught HierarchyRequestError: Failed to execute 'appendChild' on 'Node': This node type does not support this method."

#bugs repro: load original live session, jump back in time (paused), enable live session again

index.js:1 DOMException: Failed to execute 'appendChild' on 'Node': This node type does not support this method.
    at e.restoreRealParent (https://app.highlight.run/static/js/3.b33474bc.chunk.js:2:645458)
    at https://app.highlight.run/static/js/3.b33474bc.chunk.js:2:615318
    at Map.forEach (<anonymous>)
    at https://app.highlight.run/static/js/3.b33474bc.chunk.js:2:615286
    at https://app.highlight.run/static/js/3.b33474bc.chunk.js:2:568673
    at Array.map (<anonymous>)
    at Object.emit (https://app.highlight.run/static/js/3.b33474bc.chunk.js:2:568656)
    at play (https://app.highlight.run/static/js/3.b33474bc.chunk.js:2:650423)
    at https://app.highlight.run/static/js/3.b33474bc.chunk.js:2:566815
    at Array.forEach (<anonymous>)

can't repro this locally: could this be due to chunking? eg. turning off live mode loads chunk from before, then resuming live mode somehow breaks. no, live mode session isn't chunked until it's processed

@Vadman97 Vadman97 merged commit 5c10bf7 into master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants