Repository navigation
fix(desktop): require Developer ID team without a pinned identity - #221
nillikechatchat wants to merge 7 commits into
Conversation
Desktop update callers always pass expected_team=None. For developer-id packages that treated None as UPGRADE_SIGNATURE_IDENTITY_UNCONFIGURED and skipped TeamIdentifier, Developer ID Application, and spctl checks. None now requires a present TeamIdentifier plus Developer ID Application authority before spctl. A pinned team, when supplied, must still match. Fixes higress-group#218 Signed-off-by: nillikechatchat <yuanhenglizhen2050@163.com> Co-authored-by: monkeycode-ai <monkeycode-ai@chaitin.com>
Linux clippy builds the host-runtime lib without macos, so the helper was unused outside tests and failed -D warnings. Fixes higress-group#218 Signed-off-by: nillikechatchat <yuanhenglizhen2050@163.com> Co-authored-by: monkeycode-ai <monkeycode-ai@chaitin.com>
|
@johnlanni ready for review. Fixes #218. Candidate SHA Follow-up commit gates |
Review: real Developer ID upgrade blocker; preserve trusted publisher identityReviewed commit: Importance of the original issue: low immediate urgency for the current self-signed release channel, but a release-readiness blocker before distributing Developer ID packages. The current v0.3.1 macOS artifacts are self-signed and use the unaffected Change needed before merge (P1 review finding): the patch resolves the availability problem by weakening the publisher-identity requirement. In The native HTTPS source and package digest checks remain in place. However, valid Apple signing/Gatekeeper assessment alone does not establish the expected HiRoute publisher. The existing upgrade requirement retains signature-identity verification. The P1 finding concerns the trust-policy weakening introduced by this fix; it does not classify the original report as a demonstrated P1 production incident. Please:
Recommendation: fix the missing identity configuration/wiring before enabling this upgrade path, rather than broadening acceptance to every Developer ID team. |
Keep Developer ID verification fail-closed when the publisher team is unconfigured. Pass the compile-time team from the packaging identity through download, revalidation and install. Fixes higress-group#218 Signed-off-by: nillikechatchat <yuanhenglizhen2050@163.com> Co-authored-by: monkeycode-ai <monkeycode-ai@chaitin.com>
Follow-up review (2026-10-29): publisher-identity finding remains unresolvedReviewed commit: Original issue and urgency: Developer ID upgrades really do fail when callers provide no expected signing team. The original verifier fails closed with The P1 review finding still blocks this patch: The requested correction remains:
Recommendation: changes required before merge. The P1 label describes the trust-policy weakening introduced by the proposed fix, rather than a demonstrated P1 incident in the original report. The branch also remains behind main and requires the normal final checks and code-owner approval. |
…er-id-team Signed-off-by: nillikechatchat <yuanhenglizhen2050@163.com> Co-authored-by: monkeycode-ai <monkeycode-ai@chaitin.com>
…er-id-team Signed-off-by: nillikechatchat <yuanhenglizhen2050@163.com> Co-authored-by: monkeycode-ai <monkeycode-ai@chaitin.com>
|
@johnlanni Publisher-identity follow-up is on Download, revalidate and install now pass Linux tests at
This checkout has no macOS validation target, so Gatekeeper/spctl and a real Developer ID upgrade were not executed here. Hosted CI after this push is the remaining remote evidence. Human review remains the default. |
Problem
Desktop update callers always pass
expected_team=None. For developer-id packages that treatedNoneasUPGRADE_SIGNATURE_IDENTITY_UNCONFIGUREDand skipped TeamIdentifier, Developer ID Application, andspctlchecks.Change
expected_team=Nonerequires a presentTeamIdentifierplusAuthority=Developer ID Application:beforespctl.developer_id_signature_okso the identity rules are testable without codesign.Fixes #218
Validation
cargo test --locked -p hiroute-host-runtime --lib desktop_package::developer_id_signature_requires_present_team_without_pinningcargo clippy --locked -p hiroute-host-runtime --all-targets -- --deny warningspassed locally