Repository navigation
Fix trial model selection during save recovery - #519
Merged
Merged
Conversation
Keep the model choice and connection binding together so a delayed default from the previous model cannot overwrite a newer choice. Reproduce the refresh race and verify that reopening a saved result only applies it on explicit selection. Signed-off-by: 澄潭 <zty98751@alibaba-inc.com>
Treat a changed regular model binding as a newer selection when leaving review. Reopening the old save result then preserves that selection and reuses the original save. Signed-off-by: 澄潭 <zty98751@alibaba-inc.com>
…ery-selection Signed-off-by: 澄潭 <zty98751@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #518.
Verification
e71ff5d8fand passes on2e6844bf1.ed0cb5a2b. On2e6844bf1it keeps the new binding, offers the recovered model for explicit use, and records exactly oneapply_compute_savecall.