-
Notifications
You must be signed in to change notification settings - Fork 136
The installation file #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It is now easyer to install the vbaDeveloper project. You can follow the instruction that you see at the bigining of the file. We still have to install the libraries and change security level but the .xlam file is now created automaticaly.
There is also a way to automate the installation of the libraries but the VBA code need to refer to the path of the library. The problem is that the library is not always at the same place depending where you installed MS Office on your computer and what version is it (32 bit, 64 bit or 2010,2013, 2016). So I perfer to let the user select the library in the VB Editor. |
Since Installer.bas is not supposed to be a module of vbaDeveloper.xlam, shouldn't it be located in the main repository (ie. with the README) ? |
I moved the file installer.bas in the folder next to the readme. I also updated the code so that everything work correctly. Now Installer module is not visible by user after installation so this will avoid confusion by the user.
@DecimalTurn , I will let you have a look at it. I just updated branch accordingly. |
- Typos removed in the description - Adjustment of the file path to take into account the new location of Installer.bas - Replaced the loop on the lines of the module by an import command to make things simpler.
@brochuJP I've made a pull request in your patch-1 branch to include some other changes. Let me know what you think. |
It looks like it created conflicts but I have been able to manually make changes in order to get your changes merged
@hilkoc Is there any additional things you'd like to be done before merging the pull request? |
Thanks for your pull request. I hope to find the time to merge this in soon. |
I've had a closer look at this installer and compared it with the steps in src/vbaDeveloper.xlam/Build.bas. The Build.bas has 10 steps to complete the installation. Of those 10, this installer takes care of step 1, 3, 6, 7. That by itself is great, but the installer itself has an additional six steps to follow. All in all it doesn't make things any quicker. Actually it is more confusing, because now the installation steps are spread in two different files. |
It is now easyer to install the vbaDeveloper project. You can follow the instruction that you see at the bigining of the file. We still have to install the libraries and change security level but the .xlam file is now created automaticaly.