generated from hmcts/expressjs-monorepo-template
-
Notifications
You must be signed in to change notification settings - Fork 2
VIBE-175 Verified user- Account creation #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
141 commits
Select commit
Hold shift + click to select a range
3d0a4f7
Add file publication viewing with PDF and data file support
alexbottenberg dd5b887
Fix E2E tests for file publication and summary pages
alexbottenberg d23ef92
Refactor: Extract error content to separate locale files
alexbottenberg 2571328
Fix UUID type mismatch in E2E tests
alexbottenberg a1692c9
Fix file storage path to use repository root
alexbottenberg 233e174
Fix test CSS selector and remove debug logging
alexbottenberg 02b1cef
Fix unit tests for file-storage module
alexbottenberg 6af8055
Fix Welsh error content test selector
alexbottenberg b864e56
Fix 404 error page test selector
alexbottenberg 185a730
Fix page title assertion in PDF iframe test
alexbottenberg 379beb9
Fix performance test to use request API
alexbottenberg c05bb16
Fix E2E tests: use request API for download endpoints
alexbottenberg 73c7ce1
Fix language variant tests to use request API
alexbottenberg cff59f1
Fix Welsh date format test
alexbottenberg 4cc6b0a
Fix octet-stream test to use request API
alexbottenberg 20f0c81
Fix JSON content-type test to use request API
alexbottenberg 7da0321
Fix PDF file tests to use request API
alexbottenberg 8e6ff4b
Fix page title test assertion
alexbottenberg fd150f2
Refactor file storage to publication module
alexbottenberg 7a6fe6b
Merge branch 'master' into VIBE-215-Display-of-Pubs-View-Flat-File
alexbottenberg a2168a3
Refactor artefact-not-found into dedicated page folder
alexbottenberg 5ed5c0d
Fix helmet CSP frameSrc to always include 'self'
alexbottenberg 56ae8fe
Force reload of helmet middleware for test cache
alexbottenberg 10a5633
Rename local variable to avoid shadowing in getExpireDate
alexbottenberg a09c92d
Fix linter issues: formatting and false positive
alexbottenberg b55cc44
Add e2e-tests junit-results.xml to gitignore
alexbottenberg 821ffee
Refactor file-publication controller and add unit tests
alexbottenberg 95514a6
Fix E2E test workflow to handle missing junit-results.xml
alexbottenberg b6bf34c
Fix glob security vulnerabilities (GHSA-5j98-mcp5-4vw2)
alexbottenberg 881eb83
Fix E2E test for file-publication redirect behavior
alexbottenberg 96b9c66
Fix import ordering in artefact-not-found test
alexbottenberg 2018cee
Add media account creation feature with comprehensive E2E tests
alexbottenberg 3065e79
Add CHECK constraint to media_application status field
alexbottenberg a269d13
Improve multer error handling for all file upload errors
alexbottenberg a3fcf82
Improve JSON download test assertions in file-publication E2E test
alexbottenberg 354c614
Fix storage path and date sorting assertions in summary-of-publicatio…
alexbottenberg 6d931c5
Fix stray leading quote in Welsh translation for account-request-subm…
alexbottenberg 6a934d3
Fix page titles in create-media-account to reflect correct account type
alexbottenberg b108acb
Fix duplicate file upload errors by filtering existing field errors b…
alexbottenberg b29e54d
Fix case-sensitive file extension detection in file-publication-data
alexbottenberg 4f5963f
Increase CSRF token entropy from 32 to 128 bytes for better security
alexbottenberg 8e79715
Update page titles to follow GOV.UK standard format with full service…
alexbottenberg 2b5691b
Update Welsh translation for openingParagraph2 in create-media-account
alexbottenberg 1582ba2
Update Welsh idProofHint translation in create-media-account
alexbottenberg ee0e0fb
Improve error messages and translations in create-media-account
alexbottenberg 0bfacdd
Add csrf-sync dependency to apps/web to satisfy peer dependency
alexbottenberg 6322d7f
Use optional chaining for res.locals.locale access
alexbottenberg 85823d5
Add defensive runtime check for req.file before accessing properties
alexbottenberg 70ae985
Prevent orphaned files by updating DB before writing file
alexbottenberg b624619
Improve type safety for fileUploadError handling in manual-upload
alexbottenberg 5d8ff07
Merge branch 'master' into VIBE-175
alexbottenberg 10de8f3
Remove csrf-sync from root dependencies
alexbottenberg aec303f
Remove dead code in multer error handling
alexbottenberg 6c353ac
Add missing configureCsrf mock to web app tests
alexbottenberg 2d8dc60
Add missing CSRF tokens to all POST forms
alexbottenberg ece4aca
Fix CFT IDAM E2E tests to wait for navigation after form submission
alexbottenberg 302a07d
Improve CFT IDAM helper to handle /cft-login redirect timing
alexbottenberg 412e591
Fix CFT IDAM session E2E tests to wait for navigation
alexbottenberg 40916cb
Improve test coverage for apps/web/src/app.ts to meet 80% threshold
alexbottenberg 9ad3527
Add test to verify configureCsrf middleware is invoked
alexbottenberg f60ff77
Fix multer error handling tests to actually invoke middleware
alexbottenberg e398146
Fix sign-in E2E test to use correct create account link text
alexbottenberg 7fe7a6d
Fix remaining sign-in E2E tests to use correct link text
alexbottenberg f5be775
Fix Welsh language test to use correct Welsh translations
alexbottenberg 38e2689
Simplify multer error handling tests
alexbottenberg 1fd651e
Remove failing POST route tests and add documentation
alexbottenberg 45db934
Fix admin-dashboard E2E test timeout by moving beforeEach hooks
alexbottenberg 43e6388
Fix create-media-account E2E test navigation timing
alexbottenberg 4fc31f3
Fix screen reader E2E test to use correct error message text
alexbottenberg bd8272f
Fix Welsh error message in create-media-account test
alexbottenberg c0773ad
Fix error message text in create-media-account E2E tests
alexbottenberg be5b075
Merge master into VIBE-175: Consolidate CFT IDAM tests
alexbottenberg 7862b1d
Fix publication ID assertion in summary-of-publications test
alexbottenberg 56104a6
Export file storage functions from publication module
alexbottenberg 620bd02
Add missing Artefact fields to publication queries
alexbottenberg a7f2e83
Export getArtefactById from publication module
alexbottenberg 6bd93c5
Add await to validateForm call in manual-upload
alexbottenberg 6fd0ef2
Remove file-publication and file-publication-data files
alexbottenberg cc2fae4
Fix Local Admin test - add missing navigation and login
alexbottenberg f02f8a4
Improve create-media-account test error handling
alexbottenberg 0d9c2c1
Ensure upload directory exists before writing files
alexbottenberg 1838b57
Merge branch 'master' into VIBE-175
alexbottenberg 9bee10f
Fix all create-media-account form submission tests
alexbottenberg ea2afb9
Fix Prisma schema syntax error - add missing closing brace
alexbottenberg b930527
Fix repository query unit tests by adding missing mocks
alexbottenberg ef50f81
Fix summary-of-publications tests
alexbottenberg 10163cd
Improve web app test coverage to 100%
alexbottenberg 2dab4a3
Fix ReDoS vulnerability in email validation regex
alexbottenberg 7b37fb5
Fix timeout in remove-list-confirmation test
alexbottenberg 304c113
Fix E2E test for terms and conditions error message
alexbottenberg e1b3f81
Fix E2E test for remove publication validation
alexbottenberg 44beeda
Fix E2E test for autocomplete location selection
alexbottenberg 1c016f3
Remove publication-related changes not part of VIBE-175
alexbottenberg 558a8cc
Fix import for saveUploadedFile in manual-upload-summary
alexbottenberg 2e47e8b
Fix mock for saveUploadedFile in manual-upload-summary test
alexbottenberg c9c14ee
Fix manual upload E2E test failures in CI pipeline
alexbottenberg 360fddf
Add CSRF tokens to remove-list forms
alexbottenberg 1f7d341
Fix remove-publication E2E test race conditions
alexbottenberg 6ae2b23
Add unit tests for file upload middleware configuration
alexbottenberg 03caad4
Add unit tests for account-request-submitted page
alexbottenberg ab003dd
Add unit tests for CSRF middleware
alexbottenberg 34dceea
Add comprehensive unit tests for create-media-account error handling
alexbottenberg eb47726
Add unit tests for manual-upload locationId array handling (line 38)
alexbottenberg 5ba2b97
Add unit tests for file-storage error handling (lines 18-20, 25-29, 6…
alexbottenberg b029a9c
Add unit tests for defensive file check in create-media-account (line…
alexbottenberg 1daffef
Add comprehensive unit tests for app.ts configuration (lines 32-166)
alexbottenberg cfc49b8
Fix SonarQube issue: Use Set instead of Array for ALLOWED_FILE_TYPES
alexbottenberg 9740c1e
Fix SonarQube code smell: Add error logging to catch block in file-st…
alexbottenberg e6aed2c
Fix SonarQube code smell: Remove duplicate implementation in getArtef…
alexbottenberg f7fedb0
Add unit tests for handleMulterError middleware and remove v8 ignore …
alexbottenberg c83c25b
Fix security vulnerability: Add comprehensive validation to prevent d…
alexbottenberg 9710bf7
Fix test isolation: Clear cookies in beforeEach hooks to prevent sess…
alexbottenberg a945271
Improve email validation error messages to distinguish empty vs inval…
alexbottenberg ce6ef0b
Enhance keyboard navigation tests to verify complete interactions and…
alexbottenberg 74de63b
Add proper TypeScript types to multer error handling to eliminate 'any'
alexbottenberg 333c94d
Fix Windows compatibility in findRepoRoot by removing hardcoded UNIX …
alexbottenberg 7ee21fd
Fix ambiguous file matching in getUploadedFile with strict pattern va…
alexbottenberg 12a3c04
Replace console.error with structured logging in file-storage
alexbottenberg 3ea76e7
Fix app.test.ts: replace toHaveBeenCalledBefore and strengthen route …
alexbottenberg 4fc43d3
Fix keyboard navigation E2E test to be more robust
alexbottenberg 6741640
Fix keyboard submission test heading locator
alexbottenberg 638905c
Fix GHSA-wqch-xfxh-vrr4: upgrade body-parser to 2.2.1
alexbottenberg d27197f
Fix remaining toHaveBeenCalledBefore usage in app.test.ts
alexbottenberg 3bcd310
Fix validateForm mock inconsistency in manual-upload tests
alexbottenberg 8774877
Replace line-number references with behavior descriptions in manual-u…
alexbottenberg 3cf2edb
Merge master into VIBE-175
alexbottenberg d222a21
Fix CFT_IDAM_URL test to use deterministic value
alexbottenberg 579b47b
Remove duplicate @hmcts/auth mock in remove-list-confirmation test
alexbottenberg f5099c5
Treat empty locationId array as validation failure and refactor tests
alexbottenberg 3822bf1
Fix session race conditions in reference data handlers
alexbottenberg b660f36
Fix CFT IDAM E2E tests configuration
alexbottenberg 4b304ad
Add missing CSRF tokens to system admin forms
alexbottenberg 462ed38
Remove hardcoded CFT_IDAM_URL from playwright config
alexbottenberg 095740b
Fix reference-data-upload E2E tests configuration
alexbottenberg 8480cf7
Fix all remaining reference-data-upload E2E test failures
alexbottenberg 8951ab7
Remove duplicate POST route registration for /reference-data-upload
alexbottenberg 835b6d3
Update file upload middleware tests to match new limits
alexbottenberg 10f7133
Replace hardcoded past dates with dynamic future dates in E2E tests
alexbottenberg 9bab2ab
Improve date generation in E2E tests for better validation
alexbottenberg 42ac2d0
Merge branch 'master' into VIBE-175
junaidiqbalmoj 0ed93f8
Merge branch 'master' into VIBE-175
junaidiqbalmoj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add comprehensive unit tests for app.ts configuration (lines 32-166)
Added 23 new tests covering middleware configuration, route registration, and application setup: Middleware Configuration (lines 41-52, 100-137): - Test compression, urlencoded, and cookie parser middleware - Test Passport authentication configuration (line 103) - Test GOV.UK Frontend with module paths array (lines 105-125) - Verify nunjucksGlobals (gtm, dynatrace) and assetOptions - Test auth navigation middleware (line 137) - Test helmet configuration with CFT IDAM URL (lines 47-51) - Test Express session Redis with client connection (line 52) Route Registration (lines 140-156): - Test SSO callback route registration (line 140) - Test CFT callback route registration (line 143) - Test civil-and-family-daily-cause-list routes (line 146) - Test web core page routes (line 148) - Test auth routes (line 149) - Test system admin routes (line 150) - Test public pages routes (line 151) - Test verified pages routes (line 152) - Test admin routes (line 153) - Test not found handler before error handler order (lines 155-156) Redis Configuration (lines 161-166): - Test Redis client connection - Verify Redis error event handler All 40 tests now passing. Lines marked with /* v8 ignore */ (56-98) remain untested as they are better covered by E2E tests. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Loading branch information
commit 1daffef0a058b466a048fecc428321c9de50bcf2
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.