Skip to content

VIBE-241 - CaTH General Information - Cookie Policy #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NatashaAlker wants to merge 22 commits into
base: master
Choose a base branch
from
Open

VIBE-241 - CaTH General Information - Cookie Policy #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
481a336
Add technical planning for VIBE-241: Cookie Policy
github-actions[bot] Nov 21, 2025
c27d5b3
Add technical planning documentation for VIBE-241
github-actions[bot] Nov 21, 2025
1dbb803
Add technical planning for VIBE-241
github-actions[bot] Nov 22, 2025
a773f2d
Add technical planning documentation for VIBE-241
github-actions[bot] Nov 22, 2025
eca9b87
docs: Add technical plan for VIBE-241 - Cookie Policy
github-actions[bot] Nov 22, 2025
ce25bb1
Add technical planning for VIBE-241 Cookie Policy
github-actions[bot] Nov 22, 2025
355b26e
Add cookies policy page and content in English and Welsh
NatashaAlker Dec 1, 2025
f0ad35d
Update page footer
NatashaAlker Dec 1, 2025
1499340
Add analytic and performance cookies
NatashaAlker Dec 1, 2025
be7d512
Add tests
NatashaAlker Dec 1, 2025
e6d4f6b
Update task list
NatashaAlker Dec 1, 2025
ebefd22
Merge branch 'master' into feature/VIBE-241-cookie-policy
NatashaAlker Dec 1, 2025
7a7f24e
Claude's code review
NatashaAlker Dec 1, 2025
78b5c42
Merge branch 'feature/VIBE-241-cookie-policy' of github.com:hmcts/cat…
NatashaAlker Dec 1, 2025
a4be933
Fix some e2e test failures
NatashaAlker Dec 1, 2025
170c3d7
Fix faiing e2e test for cookie page table contents
NatashaAlker Dec 3, 2025
cd90152
Remove non functional welsh url and make language toggling consistent…
NatashaAlker Dec 3, 2025
9aba200
Fix failing e2e tests
NatashaAlker Dec 3, 2025
40f7c51
Update cookie-policy url and fix failing e2e test
NatashaAlker Dec 3, 2025
72a5bc3
Remove duplicate docs
NatashaAlker Dec 5, 2025
3635eff
Merge branch 'master' into feature/VIBE-241-cookie-policy
NatashaAlker Dec 5, 2025
b0a29d8
Fiz dependency scan issue
NatashaAlker Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/web/src/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@ export async function createApp(): Promise<Express> {
preferencesPath: "/cookie-preferences",
categories: {
essential: ["connect.sid"],
analytics: ["_ga", "_gid", "dtCookie", "dtSa", "rxVisitor", "rxvt"],
analytics: ["_ga", "_gid"],
performance: ["dtCookie", "dtSa", "rxVisitor", "rxvt"],
Comment on lines +84 to +85
Copy link

@coderabbitai coderabbitai bot Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

# First, let's find all TypeScript and template files that might reference cookie categories
git ls-files | grep -E "\.(ts|tsx|njk|js)$" | head -20

Repository: hmcts/cath-service

Length of output: 671

🏁 Script executed:

# Find the web app structure and cookie-related files
git ls-files | grep -E "apps/web" | head -30

Repository: hmcts/cath-service

Length of output: 920

🏁 Script executed:

# Read the app.ts file to see the cookie categories
cat -n apps/web/src/app.ts | sed -n '70,95p'

Repository: hmcts/cath-service

Length of output: 1110

🏁 Script executed:

# Search for performance category references
echo "=== Searching for 'performance' category references ==="
rg -n "performance" apps/web --type ts --type njk -C2

echo ""
echo "=== Searching for Dynatrace cookies ==="
rg -n "dtCookie|dtSa|rxVisitor|rxvt" --type ts --type njk -C2

Repository: hmcts/cath-service

Length of output: 231

🏁 Script executed:

# Search without file type filter
echo "=== Searching for 'performance' category references ==="
rg -n "performance" apps/web -C2

echo ""
echo "=== Searching for Dynatrace cookies ==="
rg -n "dtCookie|dtSa|rxVisitor|rxvt" -C2

echo ""
echo "=== Checking locale files for cookie categories ==="
grep -n "analytics\|performance" apps/web/src/locales/*.ts

Repository: hmcts/cath-service

Length of output: 10181

🏁 Script executed:

# Check the full context of apps/web/src/assets/js/index.ts around line 60
cat -n apps/web/src/assets/js/index.ts | sed -n '50,70p'

echo ""
echo "=== Check test file for performance category ==="
cat -n libs/web-core/src/pages/cookies-policy/index.test.ts | sed -n '25,40p'

Repository: hmcts/cath-service

Length of output: 1228

🏁 Script executed:

# Double-check if there's a performance category defined anywhere in assets/js/index.ts
grep -n "performance" apps/web/src/assets/js/index.ts

Repository: hmcts/cath-service

Length of output: 44

Update cookie category references in client-side cookie manifest.

The reorganization of cookies into separate analytics (Google Analytics) and performance (Dynatrace) categories in apps/web/src/app.ts is not consistently applied across the codebase:

  • apps/web/src/assets/js/index.ts line 60: Still groups all Dynatrace cookies (dtCookie, dtSa, rxVisitor, rxvt) under the analytics category instead of the new performance category.
  • libs/web-core/src/pages/cookies-policy/index.test.ts line 32: Test mock only includes dtCookie and dtSa in the performance category, missing rxVisitor and rxvt.

Add a performance category to the client-side cookie manifest in apps/web/src/assets/js/index.ts and ensure all Dynatrace cookies are moved from analytics to performance. Update the test mock to include all four Dynatrace cookies.

🤖 Prompt for AI Agents 
In apps/web/src/assets/js/index.ts around line 60 and in
libs/web-core/src/pages/cookies-policy/index.test.ts around line 32, the
Dynatrace cookies were not updated to the new performance category: modify the
client-side cookie manifest in apps/web/src/assets/js/index.ts by adding a
performance category and moving dtCookie, dtSa, rxVisitor and rxvt out of
analytics into performance (leaving analytics for GA cookies like _ga/_gid), and
update the test mock in libs/web-core/src/pages/cookies-policy/index.test.ts to
include all four Dynatrace cookies (dtCookie, dtSa, rxVisitor, rxvt) under the
performance category so the manifest and tests stay consistent.

preferences: ["language"]
}
});
Expand Down
Loading
Loading