VIBE-175 Bug Fix in Create Media Application About Error Messages #164

junaidiqbalmoj · 2025-12-03T16:03:23Z

Jira link

https://tools.hmcts.net/jira/browse/VIBE-175

Change description

Create Media Application Error Messages Fix

Summary by CodeRabbit

Bug Fixes
- Enhanced form validation with more specific and helpful error messages for each field, including checks for blank entries, whitespace issues, and format validation
- Improved error messaging clarity for email format, file size requirements, and terms acceptance
- Added granular validation feedback for full name, email, employer, and file uploads in English and Welsh

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2025-12-03T16:03:35Z

Walkthrough

This pull request introduces granular form validation error messages for the create-media-account feature, replacing generic error keys with specific ones for blank fields, whitespace issues, and format validation. Updates include new locale strings in English and Welsh, enhanced validation logic with helper functions, and comprehensive test coverage for the expanded validation scenarios.

Changes

Cohort / File(s)	Summary
Locale definitions `libs/public-pages/src/pages/create-media-account/en.ts`, `cy.ts`	Added granular error keys for full name, email, employer, and file validation (blank, whitespace, double whitespace, format). Updated message text for errorFileSize, errorEmailInvalid, and errorTermsRequired. Removed generic keys like errorFullNameRequired and errorEmployerRequired.
Locale tests `libs/public-pages/src/pages/create-media-account/index.njk.test.ts`	Updated assertions to verify new error keys and their corresponding messages across both English and Welsh locales. Expanded test coverage for the broader validation surface.
Core validation logic `libs/public-pages/src/pages/validation.ts`	Introduced helper predicates for whitespace detection. Refactored full name, email, employer, and file validation to emit specific error keys for blank, whitespace, and format failures. Added MAX_FILE_SIZE constant and file extension validation.
Validation tests `libs/public-pages/src/pages/validation.test.ts`	Expanded test cases to cover whitespace edge cases, boundary conditions, and new error scenarios. Updated expected error keys from generic (e.g., errorFullNameRequired) to granular (e.g., errorFullNameBlank, errorFullNameWhiteSpace).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

validation.ts: New helper functions and refactored validation logic across four form fields warrant careful scrutiny of error-key logic paths and boundary conditions
Locale files (en.ts, cy.ts): Verify all new error keys are correctly defined and Welsh translations are accurate
Tests: Cross-check new validation test cases align with updated validation logic, especially whitespace and format edge cases

Poem

🐰 With whiskers twitching, I hop with glee,
Your validations now precise and spry!
Blank fields caught, spaces trimmed tight,
Each error message burns ever so bright.
From generic to granular, details shine—
A form that's sturdy, every line divine! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: refactoring error messages in the Create Media Application from generic to granular validation errors.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch vibe-175-bug-fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

sonarqubecloud · 2025-12-03T16:05:15Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

coderabbitai

Actionable comments posted: 3

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)

libs/public-pages/src/pages/validation.test.ts (2)
46-65: Incorrect error message for length validation.

The test expects errorFullNameBlank ("Full name field must be populated") when the name exceeds 100 characters. This message is misleading since the field is populated - it's just too long. The validation should return a distinct error like errorFullNameTooLong with a message indicating the length constraint.

Same issue applies to the invalid characters test on line 84.
-    expect(errors[0].text).toBe(en.errorFullNameBlank);
+    // Consider adding a distinct error key for length validation:
+    // expect(errors[0].text).toBe(en.errorFullNameTooLong);
255-274: Similar issue: using blank error for length constraint.

Like the full name case, errorEmployerBlank is used when employer exceeds 120 characters. This is semantically incorrect - the field is populated, just too long.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d8c8258 and be10181.

📒 Files selected for processing (5)

libs/public-pages/src/pages/create-media-account/cy.ts (1 hunks)
libs/public-pages/src/pages/create-media-account/en.ts (1 hunks)
libs/public-pages/src/pages/create-media-account/index.njk.test.ts (3 hunks)
libs/public-pages/src/pages/validation.test.ts (7 hunks)
libs/public-pages/src/pages/validation.ts (3 hunks)

🧰 Additional context used

📓 Path-based instructions (6)

**/*.{ts,tsx}