CCD-6925: Improve validation error messages for text field min/max #2674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_length_validation_messages # Conflicts: # src/test/java/uk/gov/hmcts/ccd/domain/types/BaseLocationValidatorTest.java # src/test/java/uk/gov/hmcts/ccd/domain/types/RegionValidatorTest.java # src/test/java/uk/gov/hmcts/ccd/domain/types/TextValidatorTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CCD-6925
Change description
Currently when a text field in ExUI has a max size and the provided content exceeds it, the full field content is included in the validation error message. Sometimes that field content can be very long which makes the error message hard to read.
Ideally the content wouldn't be included at all in the validation error message, but as a light touch improvement for now I propose truncating the text value in the error message if it is longer than a certain size.
I am also suggesting to add the character count for the field value in the error message so that the user has an idea of how far over the limit they were. I have also modified the error message for the minimum length validation for consistency.
Currently the field value is truncated to 50 characters, but this could easily be changed if required.
Maximum length validation:
Before:
After:
Minimum length validation:
Before:
After:
Does this PR introduce a breaking change? (check one with "x")