LAU-1325 Add Interceptor to override token #2691
Open
+90
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyankaVerma21
changed the title
priyankaVerma21
changed the title
priyankaVerma21
changed the title
priyankaVerma21
force-pushed
the
lau-1325-use-new-token-while-retrying
branch
from
5d2e266 to
ee120d1
Compare
| return template -> { | ||
| template.removeHeader("ServiceAuthorization"); | ||
| String token = securityUtils.getServiceAuthorization(); | ||
| template.header("ServiceAuthorization", token); |
Contributor
There was a problem hiding this comment.
This will run on every single request going through feign and we need to check if performance is not going to be impacted. I believe this will run on every request, not as comment suggests - on retries only.
Contributor
rapolaskaseliscgi
left a comment
rapolaskaseliscgi
left a comment
There was a problem hiding this comment.
We need to be sure it does not impact performance.
RebeccaBaker
approved these changes
Dec 9, 2025
Collaborator
RebeccaBaker
left a comment
RebeccaBaker
left a comment
There was a problem hiding this comment.
This should be perf tested
Contributor
Actually I had a look in the existing implementation and it looks like we call s2s before each call anyway, so putting that call in the interceptor doesn't change much. We just need to make sure that the feign interceptor is not used in any other feign clients. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/LAU-1325
Change description
Add Interceptor
Does this PR introduce a breaking change? (check one with "x")