CMake build system initial implementation #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved includes, sources, bench and tests to separate directories Disabled tutorial 4 & 5 abort until i find a workaround to handle 'must fail test' Added a makefile to wrap the CMake build
Contributor
Author
|
Let me known what do you think about this implemetation.
|
hnes
added a commit
that referenced
this pull request
Jul 24, 2018
a part of PR #13 by Lucas Abel <[email protected]> Reviewed by Sen Han <[email protected]>
hnes
pushed a commit
that referenced
this pull request
Jul 24, 2018
a part of PR #13 by Lucas Abel <[email protected]> Reviewed by Sen Han <[email protected]>
Owner
|
Thank you very much for your nice contribution, @uael :D The OSX support has just been added to the master branch of libaco and would be released with the next v1.2.3. I have merged some part of the Unfortunately, because there are some higher priority things to do currently in libaco, so the Proposal "Addition of a build system generator to Test Suites" in Issue #5 would be postponed until all these goals are finished. Sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal #5
Related #8 #11
Just an overview of what could be the build system implementation.