Repository navigation
Conversation
Fixes found while re-splitting storytold#302, storytold#303 and storytold#304 from upstream main, ported onto main, where all four changes stack: - A command that reads only `id` refuses `ids` instead of acting on the selection; edit.cut no longer lists `ids`. - describe keeps animation.remove's remark with its `ids` option and offers a bare call for an all-optional set; table.split's row and col are optional; the params grammar is documented. - format.grow/shrink in Slide Master view step each level from its own size; a layout set back to a rectangle stays one under a rounded master; slides from an outline carry the template's footers; Save as Template from the app saves a .potx. - The "not available" reasons are constants; the MCP instructions name shape commands; the architecture doc names Session::call. Test fixtures use "Acme" in place of a real brand and font. VIB-11797 [claude-opus-5-5] on behalf of hoblin
format.grow and format.shrink in Slide Master view stepped every selected placeholder from the first one's sizes: the body grew 28 → 48 next to the title. format_style now tells its closure which shape it restyles. A UI test drives Save as Template through a stand-in save dialog. Doc comments and a test name say what they cover. VIB-11797 [claude-opus-5-5] on behalf of hoblin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The studio builds DeckCraft from this fork's
main. While our three upstream PRs were re-split from upstreammain(storytold#302, storytold#303, storytold#304), their self-review found and fixed real defects. Those fixes lived only on the PR branches; this brings them tomain, where all four of our changes stack.Linear: VIB-11797
Before and after
A key the command doesn't read.
shape.inspecttakesid.idis still accepted where a command listsids, since those resolve both.edit.cutno longer listsids: it copies the selection, soidscut one shape and copied another.describe animation.removeTemplates
format.growin Slide Master view stepped every level, and every selected placeholder, from one size (32, 32, 32); now each steps from its own (32, 28, 24 under a 28/24/20 master).slide.fromOutlinehad no footers; now they carry the ones the template turns on, likeslide.new..deckcraft; now it asks for a.potxand saves throughfile.saveTemplate.Smaller:
table.split'srow/colare optional, as the command reads them; the MCP instructions say "shape commands" forids; the four "not available" reasons the hints match are constants;docs/architecture.mdand the engine crate doc nameSession::callas the entry for the CLI, control channel and MCP; test fixtures use "Acme" in place of a real brand and font.How
The fix commits were ported by hand onto
main, not merged from the PR branches: those branches are built on upstreammainand carry adaptations that let each PR stand alone (no change reports for master edits, plain error texts), whichmain, with all four changes, must not take. Left out on purpose: the PR branch'sno_shapehint change, sinceslide.inspecthere does inspect a master or layout.Test plan
cargo xtask ci: fmt, clippy, tests, assets, layers, wasmshape.inspectrefusesids;describe animation.remove;growing_a_layout_placeholder_steps_each_level_from_its_own_size;a_layout_set_back_to_a_rectangle_stays_one_under_a_rounded_master;slides_from_an_outline_carry_the_footers_too;file.saveTemplatewithout a path asks for a.potx;save_template_writes_a_template_file(on disk, content type)format.growwith the master's title and body selected steps each from its own size (the body went 28 → 48 before); a UI test drives Save as Template through a stand-in save dialog and checks the.potxsuggestion and the saved fileNo new tag; the fixes ride along with the next studio deploy.
[claude-opus-5-5] on behalf of hoblin