Skip to content

Bring the upstream PR review fixes into main - #11

Merged
hoblin merged 2 commits into
mainfrom
eugene/vib-11797-bring-the-upstream-pr-fixes-into-the-deckcraft-forks-main
Oct 13, 2026
Merged

hoblin merged 2 commits into
mainfrom
eugene/vib-11797-bring-the-upstream-pr-fixes-into-the-deckcraft-forks-main

Conversation

@hoblin

@hoblin hoblin commented Oct 13, 2026 •

Copy link
Copy Markdown
Owner

The studio builds DeckCraft from this fork's main. While our three upstream PRs were re-split from upstream main (storytold#302, storytold#303, storytold#304), their self-review found and fixed real defects. Those fixes lived only on the PR branches; this brings them to main, where all four of our changes stack.

Linear: VIB-11797

Before and after

A key the command doesn't read. shape.inspect takes id.

deckcraft-cli run --print --cmd 'shape.insert={…}' --cmd 'shape.insert={…}' --cmd 'shape.inspect={"ids":[260]}'
before: shape.inspect → the selected shape, 261 (`ids` passed the check as an alias of `id`, then was ignored)
after:  `shape.inspect` was given `ids`, which it doesn't take. `shape.inspect` takes {id} → full shape JSON plus its effective box.

id is still accepted where a command lists ids, since those resolve both. edit.cut no longer lists ids: it copies the selection, so ids cut one shape and copied another.

describe animation.remove

before: …Note: all of the shapes' animations … Run it with: deckcraft-cli run --cmd 'animation.remove={…}'
after:  or:
          ids, optional  (all of the shapes' animations)
        Run it with: deckcraft-cli run --cmd animation.remove

Templates

  • format.grow in Slide Master view stepped every level, and every selected placeholder, from one size (32, 32, 32); now each steps from its own (32, 28, 24 under a 28/24/20 master).
  • A layout placeholder set back to a rectangle under a rounded master drew rounded on its slides; now it stays a rectangle.
  • Slides from slide.fromOutline had no footers; now they carry the ones the template turns on, like slide.new.
  • Save as Template from the app saved a .deckcraft; now it asks for a .potx and saves through file.saveTemplate.

Smaller: table.split's row/col are optional, as the command reads them; the MCP instructions say "shape commands" for ids; the four "not available" reasons the hints match are constants; docs/architecture.md and the engine crate doc name Session::call as the entry for the CLI, control channel and MCP; test fixtures use "Acme" in place of a real brand and font.

How

The fix commits were ported by hand onto main, not merged from the PR branches: those branches are built on upstream main and carry adaptations that let each PR stand alone (no change reports for master edits, plain error texts), which main, with all four changes, must not take. Left out on purpose: the PR branch's no_shape hint change, since slide.inspect here does inspect a master or layout.

Test plan

  • cargo xtask ci: fmt, clippy, tests, assets, layers, wasm
  • New tests: shape.inspect refuses ids; describe animation.remove; growing_a_layout_placeholder_steps_each_level_from_its_own_size; a_layout_set_back_to_a_rectangle_stays_one_under_a_rounded_master; slides_from_an_outline_carry_the_footers_too; file.saveTemplate without a path asks for a .potx; save_template_writes_a_template_file (on disk, content type)
  • Self-review: format.grow with the master's title and body selected steps each from its own size (the body went 28 → 48 before); a UI test drives Save as Template through a stand-in save dialog and checks the .potx suggestion and the saved file
  • The native save dialog clicked through by hand

No new tag; the fixes ride along with the next studio deploy.

[claude-opus-5-5] on behalf of hoblin

Fixes found while re-splitting storytold#302, storytold#303 and storytold#304
from upstream main, ported onto main, where all four changes stack:

- A command that reads only `id` refuses `ids` instead of acting on the
  selection; edit.cut no longer lists `ids`.
- describe keeps animation.remove's remark with its `ids` option and
  offers a bare call for an all-optional set; table.split's row and col
  are optional; the params grammar is documented.
- format.grow/shrink in Slide Master view step each level from its own
  size; a layout set back to a rectangle stays one under a rounded
  master; slides from an outline carry the template's footers; Save as
  Template from the app saves a .potx.
- The "not available" reasons are constants; the MCP instructions name
  shape commands; the architecture doc names Session::call.

Test fixtures use "Acme" in place of a real brand and font.

VIB-11797

[claude-opus-5-5] on behalf of hoblin
format.grow and format.shrink in Slide Master view stepped every
selected placeholder from the first one's sizes: the body grew 28 → 48
next to the title. format_style now tells its closure which shape it
restyles. A UI test drives Save as Template through a stand-in save
dialog. Doc comments and a test name say what they cover.

VIB-11797

[claude-opus-5-5] on behalf of hoblin
@hoblin
hoblin marked this pull request as ready for review October 13, 2026 07:42
@hoblin hoblin self-assigned this Oct 13, 2026
@hoblin
hoblin merged commit 9855bad into main Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant