Better error handling of non-conformant json:api responses

[theninj4]

If we get a non-conformant response to a request, we should be producing a generic json:api compliant error to pass back up the stack. Right now, we're either passing back objects that don't meet the consumers expectations, or throwing exceptions as we try and access properties that don't exist.

[pmcnr-hx]

Out of scope of this change, but is there any danger JSON.parse(payload.text) will fail to parse and throw and exception? Should we put in a try..catch block?

[theninj4]

Good call, I'll add it.

[pmcnr-hx]

Unit tests seem to be broken on CI...

[theninj4]

@pmcnr-hx the failing tests are CORS related on iOS-9.2:

Chrome 47.0.2526 (Windows 10 0.0.0): Executed 23 of 24 (skipped 1) SUCCESS (6.586 secs / 5.747 secs)
Firefox 43.0.0 (Windows 10 0.0.0): Executed 23 of 24 (skipped 1) SUCCESS (5.906 secs / 5.332 secs)
IE 11.0.0 (Windows 10 0.0.0): Executed 23 of 24 (skipped 1) SUCCESS (7.64 secs / 6.769 secs)
IE 9.0.0 (Windows 7 0.0.0): Executed 23 of 24 (skipped 1) SUCCESS (4.727 secs / 3.986 secs)
Mobile Safari 7.0.0 (iOS 7.1.0): Executed 23 of 24 (skipped 1) SUCCESS (7.087 secs / 6.307 secs)
Chrome Mobile 39.0.0 (Android 5.1.0): Executed 23 of 24 (skipped 1) SUCCESS (7.987 secs / 6.056 secs)
Mobile Safari 9.0.0 (iOS 9.2.0): Executed 11 of 24 (10 FAILED) (skipped 1) (2.367 secs / NaN secs)

[theninj4]

Tests are still as good as they're going to get 👍

[pmcnr-hx]

All good! 👍

[DuncanFenning]

Nice one 👍