Fix addition and removal of resources to/from relations #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmcnr-hx
force-pushed
the
add-related-distinct-resources
branch
from
94e864e to
ee09e76
Compare
Fix addition and removal of related resources and create system test that cover this functionality.
pmcnr-hx
force-pushed
the
add-related-distinct-resources
branch
from
ee09e76 to
cb20939
Compare
lib/Resource.js
Outdated
| if (!match) return; | ||
|
|
||
| if (relation.meta.many) { | ||
| if (Resource._rawRelationHasMany(relation)) { |
Contributor
There was a problem hiding this comment.
Can we keep the variable names consistent between functions? We pass it in here as relation and it pops out above as rawRelation
Contributor
Author
There was a problem hiding this comment.
We sure can. I would prefer to rename here though, because we're using relation to refer to both the related resources collection and the relationship metadata.
Contributor
|
👍 looks great, nice job on cleaning up |
Contributor
|
All tests pass. Nice cleanup! 👍 |
pmcnr-hx
added a commit
that referenced
this pull request
Feb 10, 2016
Fix addition and removal of resources to/from relations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the addition and removal of resources to/from relations.
The JSON:API specification mandates that if a resource is added multiple times to a relationship it should be de-duplicated (as a result the same related resource should never appear more than once in a relationship).
A typo bug is fixed in the removal of resources from relationships which was uncovered by the new system tests.
Peruse the code changes and make sure those look sane and check that the new system tests cover the previously uncovered buggy use cases.
Also note that the assets required for browser testing are now generated on demand and have been removed from the repository and cross-browser tests have been temporarily prevented from breaking the build (as always it will be possible to see in the Saucelabs badge which specific browsers are failing the tests).