Fix protobuf-javalite version to mitigate crashes#6393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We had transitive dependencies to protobuf-javalite on 3.22.3 but this version is known to have a flow that can lead to a crash of the app if a badly formed (intentionally or not) unknown field is parsed. It has been fixed in 3.25.8 and we are already using this version in the full flavor from our sentry dependency (so it mostly only impacts :wear module and minimal flavor).
This is not the latest version of protobuf-javalite (today it is 4.33.5) but we can't bump to protobuf 4 since the underlying dependencies are not yet compatible with it. I expect renovate to open a PR to bump the version but we should close it.