Skip to content

Update to Homie Convention v2.0.1 #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 30, 2018
Merged

Update to Homie Convention v2.0.1 #507

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b884730
Fix #446 CORS Issue
timpur Mar 18, 2018
f3cc890
Fix for #477
timpur Mar 18, 2018
07219fc
Fix Lint
timpur Mar 18, 2018
259841f
Merge branch 'develop' of https://github.com/marvinroger/homie-esp826…
timpur Mar 19, 2018
072fd9a
Merge branch 'develop' of https://github.com/marvinroger/homie-esp826…
timpur Mar 19, 2018
7f2acdb
Fix Warnings
timpur Mar 19, 2018
9e83c6a
Minor Change from string to strcmp
timpur Mar 19, 2018
6ffa5ab
merge dev
timpur Mar 26, 2018
e229bc1
Update to use homie convention v2.0.1
timpur Mar 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
merge dev
  • Loading branch information
@timpur
timpur committed Mar 26, 2018
commit 6ffa5ab1babc628fa4495df49ec8cdf66f406cac
2 changes: 1 addition & 1 deletion src/Homie/Boot/BootConfig.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ void BootConfig::_onDeviceInfoRequest(AsyncWebServerRequest *request) {
for (IHomieSetting* iSetting : IHomieSetting::settings) {
JsonObject& jsonSetting = jsonBuffer.createObject();

if (strcmp(iSetting->getType()), "unknown") != 0) {
if (strcmp(iSetting->getType(), "unknown") != 0) {
Copy link
Member

@euphi euphi Mar 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why strcmp?

Copy link
Contributor Author

@timpur timpur Mar 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the core of the lib, we should try avoid using String. String will copy the chars into dynamic memory even for something as simple as this... Using String everywhere can lead to heep fragmentation.

jsonSetting["name"] = iSetting->getName();
jsonSetting["description"] = iSetting->getDescription();
jsonSetting["type"] = iSetting->getType();
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.