Skip to content

Use recursive config patching #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2020
Merged

Use recursive config patching #653

merged 1 commit into from
Jan 14, 2020

Conversation

@mkfrey
Copy link
Contributor

@mkfrey mkfrey commented Jan 9, 2020

  • More flexible patching
  • Better readable code

@mkfrey
Copy link
Contributor Author

mkfrey commented Jan 9, 2020

This PR is a rebased and updated copy of #628.

The behaviour of the patching has now slightly changed. When an element in the patch JSON has a value of null, the element with the same name in the config will now be removed, instead of being set to null.

@mkfrey mkfrey force-pushed the develop-v3-recursive-patching branch 2 times, most recently from 120edf4 to 9e50ad8 Compare January 9, 2020 13:52
@mkfrey
Copy link
Contributor Author

mkfrey commented Jan 9, 2020

Had to force push. Somehow the commit still had the old code.

@mkfrey
Use recursive config patching
3901480 
* More flexible patching
* Better readable code
@mkfrey mkfrey force-pushed the develop-v3-recursive-patching branch from 9e50ad8 to 3901480 Compare January 9, 2020 13:54
@kleini kleini self-requested a review January 9, 2020 16:14
kleini
kleini approved these changes Jan 14, 2020
View reviewed changes
Copy link
Collaborator

@kleini kleini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bodiroga bodiroga merged commit 7494c59 into homieiot:develop Jan 14, 2020
@mkfrey mkfrey mentioned this pull request Mar 13, 2020
Closed
@mkfrey mkfrey deleted the develop-v3-recursive-patching branch March 13, 2020 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kleini kleini kleini approved these changes

@euphi euphi euphi approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mkfrey @kleini @euphi @bodiroga