Limit in/out buffer growth with a Vec<u8> wrapper #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 17, 2020
ordian
reviewed
Sep 18, 2020
This was referenced Sep 25, 2020
Collaborator
|
Sorry, I had notifications muted for this repository. I don't have time nor motivation for open source these days but I'd be happy to add someone as maintainer |
Hey, no problem. It would be nice if you could invite @maciejhirsz to the repo and on crates.io :) |
Collaborator
|
I actually don't have the rights to do so @housleyjk if you could do it, that'd be nice |
|
@housleyjk Any thoughts on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
CappedBufferwrapper around aVec<u8>which effectively enforces buffer capacity limits. Exceeding capacity limits will force a disconnect.There are changes to the settings involved, so this is a breaking change.
Fixes #291.