Skip to content

Conversation

@nwoltman
Copy link
Contributor

@nwoltman nwoltman commented Feb 3, 2017

Currently when installing HTMLHint, npm is warning about a deprecated version of minimatch.
This updates the jshint dependency which is the culprit of the warning.

Currently when installing HTMLHint, npm is warning about a deprecated version of minimatch.
This updates the jshint dependency which currently uses and old version of minimatch.
@coveralls
Copy link

coveralls commented Feb 3, 2017

Coverage Status

Coverage remained the same at 98.734% when pulling d6c8876 on nwoltman:patch-1 into 152a114 on yaniswang:master.

@nwoltman
Copy link
Contributor Author

@yaniswang *ping*

@yaniswang yaniswang merged commit 60447c9 into htmlhint:master Feb 13, 2017
@nwoltman nwoltman deleted the patch-1 branch February 13, 2017 05:46
@mikermcneil
Copy link

@yaniswang would you mind publishing this to NPM? We'd like to include htmlhint in one of the default builds of Sails, and this deprecation message is all that's stopping that from happening. Great work btw!

@mikermcneil
Copy link

OK, for purposes of time, I went ahead and published a fork. Also removed a couple of other annoying deprecation messages:

Before:
image

After:
image

All dependency semver ranges are still pinned 👍

I hope we can switch back to using this package in the future! In the mean time, our fork is published as @sailshq/htmlhint, and now has no deprecation warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants