Merged
Conversation
- Sample showing a started refactor for riemann. - This will be useful/needed for Riemann mTLS. - Goal is to define args on the exporters to allow a maximum flexibility. (usage of various options like group options etc...) - Avoid the code in main to choose between args with default values and no default values as this is not flexible at all.
0ab8ce8 to
818ca21
Compare
- Refactor args for Riemann.
- Refactor args for Stdout.
- Refactor args for Json.
- Refactor args for Prometheus.
- Refactor args for Qemu.
- Refactor args for Warp10.
- Finalize refactor.
Collaborator
Author
|
Finally I did it completely, it makes the code simple and more flexible. However it will conflict with #98. |
bpetit
approved these changes
Apr 27, 2021
Contributor
|
This is great, thanks. I agree on merging this one too before merging #98 |
Collaborator
Author
|
👍 😸 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flexibility. (usage of various options like group options etc...)
no default values as this is not flexible at all.