Conversation
Collaborator
|
Looks fine to me. To get timestamp in the json exporter we should probably use the MetricGenerator in that exporter too (and the stdout too, for consistency) . Ideally that should be done before merging this PR as it might induce some changes. Should I implement this in this PR or in another one ? |
Contributor
Author
|
Hi @PierreRust ! I've started refactoring the stdout and json exporters to use MetricGenerator. I'd love to read your thoughts about the code ! Once done we'll be able to merge this PR ! 🥳 |
plus process and host power metrics are coming from MetricGenerator
bpetit
commented
Sep 30, 2021
Contributor
Author
bpetit
left a comment
bpetit
left a comment
There was a problem hiding this comment.
first review, waiting for another one from someone else
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.