Add Qemu back to the list of features#381
Merged
bpetit merged 1 commit intohubblo-org:devfrom Oct 17, 2024
Merged
Conversation
Contributor
|
Hi, thanks for the PR ! This has to be reintroduced but I'm almost sure there was a reason. I'll run some tests to ensure is works properly, then merge your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason Qemu is not in the list of features in Cargo.toml, making it unavailable to anyone using 1.0.0, even though it is referenced in the documentation.
I tried to look around for any discussions as to why this feature was disabled. I could not find any so I'm making the assumption that this was not deliberate and possibly happened due to a merge conflict.