Skip to content

Persistent menu button url #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2019
Merged

Persistent menu button url #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e52360
fix: buttons open links directly
imOscarCrespo Aug 26, 2019
0ee5a01
remove consoles
imOscarCrespo Aug 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/botonic-react/src/components/button.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,10 @@ export const Button = props => {
if (props.webview) openWebview(props.webview, props.params)
else if (props.path) sendPayload(`__PATH_PAYLOAD__${props.path}`)
else if (props.payload) sendPayload(props.payload)
else if (props.url) window.open(props.url)
else if (props.onClick) props.onClick()
else if (props.url) {
window.open(props.url)
props.onClick()
} else if (props.onClick) props.onClick()
}

const renderBrowser = () => {
Expand Down
7 changes: 6 additions & 1 deletion packages/botonic-react/src/webchat/webchat.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,12 @@ export const Webchat = forwardRef((props, ref) => {
<PersistentMenu>
{Object.values(props.persistentMenu).map((e, i) => {
return (
<Button payload={e.payload} key={i}>
<Button
onClick={closeMenu}
url={e.url}
payload={e.payload}
key={i}
>
{Object.values(e.label)}
</Button>
)
Expand Down