Correctly handle creating model index json files when setting compiled modules in pipelines. #6436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Setting a pipeline component to a compiled module and then calling
save_pretrained
results in an incorrectmodel_index.json
file being created for the pipeline. This is because the compiled module isn't unwrapped before registering to config.This PR:
Moves a block of code in
register_modules
into a helper function that correctly unwraps the compiled module and extracts the correct library and class name. We can then apply this function everywhere that is needed to extract the library, class tuple.So it should also handle pipeline modules like MultiControlNet.
Fixes # (issue)
#5617
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.