-
Notifications
You must be signed in to change notification settings - Fork 6.4k
Update installation.md #6438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update installation.md #6438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update!
docs/source/en/installation.md
Outdated
<pt> | ||
```bash | ||
pip install diffusers["torch"] transformers | ||
Note - PyTorch doesn't support Python 3.12 on Windows. Please use Python 3.11 instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be placed outside of the code block and preferably before it :)
Note - PyTorch doesn't support Python 3.12 on Windows. Please use Python 3.11 instead. | |
PyTorch only supports Python 3.8 - 3.11 on Windows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @stevhliu, actually @patrickvonplaten suggested to place it inside the the Pytorch framework placeholder. Should I place this before the Pytorch block?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, what I meant is it should be outside of the bash
code block but inside the <pt>
one like this:
<pt>
PyTorch only supports Python 3.8 - 3.11 on Windows.
<code snippet here>
</pt>
Hi @patrickvonplaten, can you please review this? Thanks |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Hi @stevhliu , can you please merge this into the main branch? Thanks |
Hi, we can merge once this comment is addressed :) |
Sorry I missed that. I will complete this. |
Hi @stevhliu, I have updated the file. Please check once. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
* Update installation.md * Update installation.md * Update installation.md
What does this PR do?
Fixes #5712.
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.