Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make fetch_job_logs() default to follow=False for consistency
Per maintainer feedback, align the Python API default with the CLI:
both now default to non-blocking (follow=False). The two internal call
sites that need streaming (jobs_run, jobs_uv_run without --detach)
already pass follow=True explicitly.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
  • Loading branch information
davanstrien and claude committed Feb 6, 2026
commit 97f49fa4128abacdd57fcb9115f17662de074995
2 changes: 1 addition & 1 deletion src/huggingface_hub/hf_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -10335,7 +10335,7 @@ def fetch_job_logs(
*,
job_id: str,
namespace: Optional[str] = None,
follow: bool = True,
follow: bool = False,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a breaking change no? we should probably set the default value to True and only the CLI should default to False

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't see @Wauplin's comment. ok to break this then 👍

token: Union[bool, str, None] = None,
) -> Iterable[str]:
"""
Expand Down
Loading