Repository navigation
Make hf jobs logs agent-friendly with --follow/-f and --tail/-n flags
#3783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0707ad9
Add `--follow/-f` and `--tail/-n` flags to `hf jobs logs`
davanstrien 97f49fa
Make `fetch_job_logs()` default to `follow=False` for consistency
davanstrien 305b5cf
Merge branch 'main' into jobs-logs-follow
davanstrien 3af4150
Move `deque` import to module level
davanstrien 80c38c7
Raise error when --follow and --tail are used together
davanstrien 89f6e1e
Move `follow` parameter into `_fetch_running_job_sse`
davanstrien File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Make
fetch_job_logs() default to follow=False for consistency
Per maintainer feedback, align the Python API default with the CLI: both now default to non-blocking (follow=False). The two internal call sites that need streaming (jobs_run, jobs_uv_run without --detach) already pass follow=True explicitly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Loading branch information
commit 97f49fa4128abacdd57fcb9115f17662de074995
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a breaking change no? we should probably set the default value to
Trueand only the CLI should default toFalseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't see @Wauplin's comment. ok to break this then 👍