Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/huggingface_hub/_revision.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,5 +39,9 @@ def __new__(cls, resolved: str, initial: str | None = None) -> "ResolvedRevision
revision.resolved = resolved
return revision

def __reduce__(self):
# without this, pickle/copy rebuild the instance from its string value only, losing `initial` and `resolved`
return self.__class__, (self.resolved, self.initial)

def __repr__(self) -> str:
return f"ResolvedRevision(initial={self.initial!r}, resolved={self.resolved!r})"
11 changes: 11 additions & 0 deletions tests/test_snapshot_download.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import copy
import os
import pickle
from pathlib import Path
from unittest.mock import MagicMock, patch

Expand Down Expand Up @@ -361,6 +363,15 @@ def test_revision_str():
assert revision.resolved == COMMIT_HASH


def test_revision_str_is_picklable():
revision = ResolvedRevision(resolved=COMMIT_HASH, initial="refs/pr/4")

for restored in (pickle.loads(pickle.dumps(revision)), copy.deepcopy(revision)):
assert restored == "refs/pr/4"
assert restored.initial == "refs/pr/4"
assert restored.resolved == COMMIT_HASH


class TestResolveRevision:
@pytest.fixture(scope="class", autouse=True)
def _shared_repo(self, request, api: HfApi):
Expand Down
Loading