Repository navigation
[Buckets] Send mtime when copying files - #4920
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
This PR has been shipped as part of the v1.32.0 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug original reported in #4752 (comment). Let's address it separately in this PR
Summary
mtimeoncopyFileoperations; regular uploads already send it.mtime=Nonewithout the fix; both pass with it.make stylepasses.make qualityhits an existing type error inserialization/_torch.py:788, also reproduced on unchanged HEAD.Note
Low Risk
Single-field addition to bucket sync JSON for copy operations, with staging integration tests only; no auth or data-model changes.
Overview
Bucket copy operations now include
mtimein the batch sync payload, matching what add/upload operations already send. Without this field, copied bucket entries could end up with missing or incorrect modification times on the Hub.Integration tests on staging assert exact timestamps: the same-bucket copy test patches
time.timeduringcopy_files, and the bucket XET upload test setsos.utimeon a file uploaded from disk.Reviewed by Cursor Bugbot for commit b43abb9. Bugbot is set up for automated code reviews on this repo. Configure here.