Repository navigation
[hfh 2.x] Merge main after PrivateLink update - #4985
Merged
Merged
Conversation
) * [HfFileSystem] Make `lpath` optional in `get_file` (fsspec>=2026.9.0) fsspec 2026.9.0 made `lpath` optional in `AbstractFileSystem.get_file` (it can be omitted when `outfile` is provided). Our override kept it required, which the latest `ty` flags as an invalid method override and fails CI. Make `lpath=None` in the signature and raise a clear ValueError if neither `lpath` nor `outfile` is provided. No behavior change otherwise. * fix get_file branching to match fsspec --------- Co-authored-by: Celina Hanouti <hanouticelina@gmail.com>
…"24 hours ago" instead of rolling over (#4943) * Roll `format_timesince` over to the next unit at the boundary `format_timesince` showed "60 seconds ago", "60 minutes ago" and "24 hours ago" at the exact unit boundaries instead of rolling over to the next unit, because the per-unit max values were 60/60/24 rather than 59/59/23. Days (6 -> 1 week) and months (11 -> 1 year) already rolled correctly; this brings seconds, minutes and hours in line. Adds the boundary cases to the test. * Update src/huggingface_hub/utils/_parsing.py --------- Co-authored-by: célina <hanouticelina@gmail.com>
…ad submodule (#4945) * Fix Windows conftest failing on lazy-loaded `file_download` submodule The `disable_symlinks_on_windows_ci` autouse fixture (active on Windows via `DISABLE_SYMLINKS_IN_WINDOWS_TESTS=1` in pyproject.toml) accesses `huggingface_hub.file_download` as a monkeypatch target. Since the package loads submodules lazily, this attribute only exists if something else already imported the submodule. Running a test subset that doesn't (e.g. `pytest tests/test_utils_headers.py`) errors every test at setup with `AttributeError: No huggingface_hub attribute file_download`. Use the string-target form of `monkeypatch.setattr`, which imports the submodule itself. Co-Authored-By: Claude Code <noreply@anthropic.com> * Update tests/conftest.py --------- Co-authored-by: dltsum <dltsum@users.noreply.github.com> Co-authored-by: Claude Code <noreply@anthropic.com> Co-authored-by: célina <hanouticelina@gmail.com>
The Hub accepts buckets as watched items, but `hf webhooks create --watch bucket:...` fails client-side because the CLI derives its valid types from `WebhookWatchedItem.type`, which lacked "bucket". Claude-Session: https://claude.ai/code/session_015YLK3QPDdiiZGuDxoFrEag Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
* [MCP] Follow nextCursor when listing tools in MCPClient add_mcp_server called list_tools() once, so tools past a server's first tools/list page were never registered, and allowed_tools could filter down to nothing. Page through with the cursor until nextCursor is empty. * [MCP] Keep the first list_tools() call cursor-free and require mcp>=1.9.4 mcp 1.8.x's list_tools() takes no cursor at all, and before 1.9.4 the cursor is sent outside params, so a paginating server returns page one forever. Call list_tools() plainly first so non-paginated servers behave as before, and raise the extra's floor to the first release that paginates correctly.
* [CLI] Align the `hf` package's python_requires with huggingface_hub `huggingface_hub` moved to `python_requires=">=3.10.0"` in #4856, but `utils/hf/setup.py` was left at `">=3.9.0"`. The `hf` package is only a console script that imports `huggingface_hub` and pins `huggingface_hub=={version}`, so the published metadata now contradicts itself: PyPI shows `hf` 1.32.0 as `Requires-Python: >=3.9.0` while the `huggingface_hub==1.32.0` it depends on is `>=3.10.0`. On Python 3.9 that resolves two ways, both wrong: $ pip install hf Successfully installed hf-1.8.0 huggingface_hub-1.8.0 # silently 24 versions stale $ pip install hf==1.32.0 ERROR: Could not find a version that satisfies the requirement huggingface_hub==1.32.0 (from hf) ERROR: No matching distribution found for huggingface_hub==1.32.0 The first is the damaging one: `uvx hf`, the usage the README documents, reports version 1.8.0 on a 3.9 interpreter with no error and no warning, so a user can be years out of date without any signal. Set `python_requires` to match the root setup.py and add a test asserting the two stay equal, since the root cause is that they are edited independently and nothing tied them together. Verification: $ python -m build --wheel # in utils/hf Requires-Python: >=3.10.0 Requires-Dist: huggingface_hub==1.33.0.dev0 Signed-off-by: Sharvil Saxena <sharvil.saxena@gmail.com> * no need to add tests * Update utils/hf/setup.py --------- Signed-off-by: Sharvil Saxena <sharvil.saxena@gmail.com> Co-authored-by: célina <hanouticelina@gmail.com>
* [CLI] Honor CLAUDE_CONFIG_DIR in hf skills add -g --claude * remove test
* [CLI] Always install skills for Claude Code, deprecate --claude * show --claude as deprecated in help instead of hiding it * remove test
* [Buckets] Raise when a batch reports failed operations * fix pickling of BucketBatchError * keep only the main test * Update src/huggingface_hub/hf_api.py Co-authored-by: Lucain <lucain@huggingface.co> * fix missing parenthesis * use a real test against staging * keep sending chunks after a failure * fold batch tests into one --------- Co-authored-by: Lucain <lucain@huggingface.co>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
`os.path.dirname("file.txt")` is "", and `os.makedirs("")` raises
FileNotFoundError. Fall back to the current directory, matching fsspec's
base `get_file` and gcsfs (fsspec/gcsfs#618).
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
A job with no `permissions:` block inherits whatever the repository hands out. Each block added here grants what that job's own steps need and nothing more. Co-authored-by: hf-security-analysis[bot] <265538906+hf-security-analysis[bot]@users.noreply.github.com>
…oint (#4966) * Send PrivateLink config under privateService in create_inference_endpoint * [Inference] Keep account_id compatible for endpoint creation * [Inference] Remove account_id compatibility test --------- Co-authored-by: Lucain Pouget <lucainp@gmail.com>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Wauplin
added a commit
that referenced
this pull request
Sep 24, 2026
* [hfh 2.x] Remove deprecated APIs (#4955) * [hfh 2.x] Remove deprecated APIs * [hfh 2.x] Keep deprecation helpers and legacy-argument shim Restore `utils/_deprecation.py` (`_deprecate_arguments`, `_deprecate_method`, `_deprecate_positional_args`) and its tests: they are unused now that the deprecated APIs are gone, but we want them ready for the next deprecation cycle. The `@pytest.mark.deprecated` harness (`expect_deprecation_marker` fixture) is kept alongside them for the same reason. Also restore `smoothly_deprecate_legacy_arguments` and its call in `validate_hf_hub_args`, so `proxies`, `resume_download`, `force_filename` and `local_dir_use_symlinks` keep being ignored with a warning instead of raising. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * [Inference] Resolve endpoint token before creating clients --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> * [hfh 2.x] Merge main into v2.0 dev branch (#4971) * [HfFileSystem] Make lpath optional in get_file (fsspec>=2026.9.0) (#4951) * [HfFileSystem] Make `lpath` optional in `get_file` (fsspec>=2026.9.0) fsspec 2026.9.0 made `lpath` optional in `AbstractFileSystem.get_file` (it can be omitted when `outfile` is provided). Our override kept it required, which the latest `ty` flags as an invalid method override and fails CI. Make `lpath=None` in the signature and raise a clear ValueError if neither `lpath` nor `outfile` is provided. No behavior change otherwise. * fix get_file branching to match fsspec --------- Co-authored-by: Celina Hanouti <hanouticelina@gmail.com> * Fix `format_timesince` showing "60 seconds ago" / "60 minutes ago" / "24 hours ago" instead of rolling over (#4943) * Roll `format_timesince` over to the next unit at the boundary `format_timesince` showed "60 seconds ago", "60 minutes ago" and "24 hours ago" at the exact unit boundaries instead of rolling over to the next unit, because the per-unit max values were 60/60/24 rather than 59/59/23. Days (6 -> 1 week) and months (11 -> 1 year) already rolled correctly; this brings seconds, minutes and hours in line. Adds the boundary cases to the test. * Update src/huggingface_hub/utils/_parsing.py --------- Co-authored-by: célina <hanouticelina@gmail.com> * Fix Windows conftest erroring test subsets on lazy-loaded file_download submodule (#4945) * Fix Windows conftest failing on lazy-loaded `file_download` submodule The `disable_symlinks_on_windows_ci` autouse fixture (active on Windows via `DISABLE_SYMLINKS_IN_WINDOWS_TESTS=1` in pyproject.toml) accesses `huggingface_hub.file_download` as a monkeypatch target. Since the package loads submodules lazily, this attribute only exists if something else already imported the submodule. Running a test subset that doesn't (e.g. `pytest tests/test_utils_headers.py`) errors every test at setup with `AttributeError: No huggingface_hub attribute file_download`. Use the string-target form of `monkeypatch.setattr`, which imports the submodule itself. Co-Authored-By: Claude Code <noreply@anthropic.com> * Update tests/conftest.py --------- Co-authored-by: dltsum <dltsum@users.noreply.github.com> Co-authored-by: Claude Code <noreply@anthropic.com> Co-authored-by: célina <hanouticelina@gmail.com> * [Webhooks] Allow `bucket` as a watched item type (#4958) The Hub accepts buckets as watched items, but `hf webhooks create --watch bucket:...` fails client-side because the CLI derives its valid types from `WebhookWatchedItem.type`, which lacked "bucket". Claude-Session: https://claude.ai/code/session_015YLK3QPDdiiZGuDxoFrEag Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> * [MCP] Follow nextCursor when listing tools in MCPClient (#4960) * [MCP] Follow nextCursor when listing tools in MCPClient add_mcp_server called list_tools() once, so tools past a server's first tools/list page were never registered, and allowed_tools could filter down to nothing. Page through with the cursor until nextCursor is empty. * [MCP] Keep the first list_tools() call cursor-free and require mcp>=1.9.4 mcp 1.8.x's list_tools() takes no cursor at all, and before 1.9.4 the cursor is sent outside params, so a paginating server returns page one forever. Call list_tools() plainly first so non-paginated servers behave as before, and raise the extra's floor to the first release that paginates correctly. * Align the `hf` package's python_requires with huggingface_hub (#4959) * [CLI] Align the `hf` package's python_requires with huggingface_hub `huggingface_hub` moved to `python_requires=">=3.10.0"` in #4856, but `utils/hf/setup.py` was left at `">=3.9.0"`. The `hf` package is only a console script that imports `huggingface_hub` and pins `huggingface_hub=={version}`, so the published metadata now contradicts itself: PyPI shows `hf` 1.32.0 as `Requires-Python: >=3.9.0` while the `huggingface_hub==1.32.0` it depends on is `>=3.10.0`. On Python 3.9 that resolves two ways, both wrong: $ pip install hf Successfully installed hf-1.8.0 huggingface_hub-1.8.0 # silently 24 versions stale $ pip install hf==1.32.0 ERROR: Could not find a version that satisfies the requirement huggingface_hub==1.32.0 (from hf) ERROR: No matching distribution found for huggingface_hub==1.32.0 The first is the damaging one: `uvx hf`, the usage the README documents, reports version 1.8.0 on a 3.9 interpreter with no error and no warning, so a user can be years out of date without any signal. Set `python_requires` to match the root setup.py and add a test asserting the two stay equal, since the root cause is that they are edited independently and nothing tied them together. Verification: $ python -m build --wheel # in utils/hf Requires-Python: >=3.10.0 Requires-Dist: huggingface_hub==1.33.0.dev0 Signed-off-by: Sharvil Saxena <sharvil.saxena@gmail.com> * no need to add tests * Update utils/hf/setup.py --------- Signed-off-by: Sharvil Saxena <sharvil.saxena@gmail.com> Co-authored-by: célina <hanouticelina@gmail.com> * Remove dots from allowed characters in job labels. (#4962) * [CLI] Honor `CLAUDE_CONFIG_DIR` in `hf skills add -g --claude` (#4957) * [CLI] Honor CLAUDE_CONFIG_DIR in hf skills add -g --claude * remove test * [CLI] Always install skills for Claude Code, deprecate --claude (#4967) * [CLI] Always install skills for Claude Code, deprecate --claude * show --claude as deprecated in help instead of hiding it * remove test --------- Signed-off-by: Sharvil Saxena <sharvil.saxena@gmail.com> Co-authored-by: Assaf Vayner <assaf@huggingface.co> Co-authored-by: Celina Hanouti <hanouticelina@gmail.com> Co-authored-by: Sreekant Baheti <60787859+Sreekant13@users.noreply.github.com> Co-authored-by: DltsumCtnori <lllalllbpear@gmail.com> Co-authored-by: dltsum <dltsum@users.noreply.github.com> Co-authored-by: Claude Code <noreply@anthropic.com> Co-authored-by: Daniel van Strien <davanstrien@users.noreply.github.com> Co-authored-by: Kayvan Zahiri <123409429+Kayvan-Zahiri@users.noreply.github.com> Co-authored-by: Sharvil Saxena <97365286+sharziki@users.noreply.github.com> Co-authored-by: shaun smith <1936278+evalstate@users.noreply.github.com> * [CLI] Remove deprecated --claude option in 2.x (#4970) * [hfh 2.x] Merge main after PrivateLink update (#4985) * [HfFileSystem] Make lpath optional in get_file (fsspec>=2026.9.0) (#4951) * [HfFileSystem] Make `lpath` optional in `get_file` (fsspec>=2026.9.0) fsspec 2026.9.0 made `lpath` optional in `AbstractFileSystem.get_file` (it can be omitted when `outfile` is provided). Our override kept it required, which the latest `ty` flags as an invalid method override and fails CI. Make `lpath=None` in the signature and raise a clear ValueError if neither `lpath` nor `outfile` is provided. No behavior change otherwise. * fix get_file branching to match fsspec --------- Co-authored-by: Celina Hanouti <hanouticelina@gmail.com> * Fix `format_timesince` showing "60 seconds ago" / "60 minutes ago" / "24 hours ago" instead of rolling over (#4943) * Roll `format_timesince` over to the next unit at the boundary `format_timesince` showed "60 seconds ago", "60 minutes ago" and "24 hours ago" at the exact unit boundaries instead of rolling over to the next unit, because the per-unit max values were 60/60/24 rather than 59/59/23. Days (6 -> 1 week) and months (11 -> 1 year) already rolled correctly; this brings seconds, minutes and hours in line. Adds the boundary cases to the test. * Update src/huggingface_hub/utils/_parsing.py --------- Co-authored-by: célina <hanouticelina@gmail.com> * Fix Windows conftest erroring test subsets on lazy-loaded file_download submodule (#4945) * Fix Windows conftest failing on lazy-loaded `file_download` submodule The `disable_symlinks_on_windows_ci` autouse fixture (active on Windows via `DISABLE_SYMLINKS_IN_WINDOWS_TESTS=1` in pyproject.toml) accesses `huggingface_hub.file_download` as a monkeypatch target. Since the package loads submodules lazily, this attribute only exists if something else already imported the submodule. Running a test subset that doesn't (e.g. `pytest tests/test_utils_headers.py`) errors every test at setup with `AttributeError: No huggingface_hub attribute file_download`. Use the string-target form of `monkeypatch.setattr`, which imports the submodule itself. Co-Authored-By: Claude Code <noreply@anthropic.com> * Update tests/conftest.py --------- Co-authored-by: dltsum <dltsum@users.noreply.github.com> Co-authored-by: Claude Code <noreply@anthropic.com> Co-authored-by: célina <hanouticelina@gmail.com> * [Webhooks] Allow `bucket` as a watched item type (#4958) The Hub accepts buckets as watched items, but `hf webhooks create --watch bucket:...` fails client-side because the CLI derives its valid types from `WebhookWatchedItem.type`, which lacked "bucket". Claude-Session: https://claude.ai/code/session_015YLK3QPDdiiZGuDxoFrEag Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> * [MCP] Follow nextCursor when listing tools in MCPClient (#4960) * [MCP] Follow nextCursor when listing tools in MCPClient add_mcp_server called list_tools() once, so tools past a server's first tools/list page were never registered, and allowed_tools could filter down to nothing. Page through with the cursor until nextCursor is empty. * [MCP] Keep the first list_tools() call cursor-free and require mcp>=1.9.4 mcp 1.8.x's list_tools() takes no cursor at all, and before 1.9.4 the cursor is sent outside params, so a paginating server returns page one forever. Call list_tools() plainly first so non-paginated servers behave as before, and raise the extra's floor to the first release that paginates correctly. * Align the `hf` package's python_requires with huggingface_hub (#4959) * [CLI] Align the `hf` package's python_requires with huggingface_hub `huggingface_hub` moved to `python_requires=">=3.10.0"` in #4856, but `utils/hf/setup.py` was left at `">=3.9.0"`. The `hf` package is only a console script that imports `huggingface_hub` and pins `huggingface_hub=={version}`, so the published metadata now contradicts itself: PyPI shows `hf` 1.32.0 as `Requires-Python: >=3.9.0` while the `huggingface_hub==1.32.0` it depends on is `>=3.10.0`. On Python 3.9 that resolves two ways, both wrong: $ pip install hf Successfully installed hf-1.8.0 huggingface_hub-1.8.0 # silently 24 versions stale $ pip install hf==1.32.0 ERROR: Could not find a version that satisfies the requirement huggingface_hub==1.32.0 (from hf) ERROR: No matching distribution found for huggingface_hub==1.32.0 The first is the damaging one: `uvx hf`, the usage the README documents, reports version 1.8.0 on a 3.9 interpreter with no error and no warning, so a user can be years out of date without any signal. Set `python_requires` to match the root setup.py and add a test asserting the two stay equal, since the root cause is that they are edited independently and nothing tied them together. Verification: $ python -m build --wheel # in utils/hf Requires-Python: >=3.10.0 Requires-Dist: huggingface_hub==1.33.0.dev0 Signed-off-by: Sharvil Saxena <sharvil.saxena@gmail.com> * no need to add tests * Update utils/hf/setup.py --------- Signed-off-by: Sharvil Saxena <sharvil.saxena@gmail.com> Co-authored-by: célina <hanouticelina@gmail.com> * Remove dots from allowed characters in job labels. (#4962) * [CLI] Honor `CLAUDE_CONFIG_DIR` in `hf skills add -g --claude` (#4957) * [CLI] Honor CLAUDE_CONFIG_DIR in hf skills add -g --claude * remove test * [CLI] Always install skills for Claude Code, deprecate --claude (#4967) * [CLI] Always install skills for Claude Code, deprecate --claude * show --claude as deprecated in help instead of hiding it * remove test * [Buckets] Raise when a batch reports failed operations (#4954) * [Buckets] Raise when a batch reports failed operations * fix pickling of BucketBatchError * keep only the main test * Update src/huggingface_hub/hf_api.py Co-authored-by: Lucain <lucain@huggingface.co> * fix missing parenthesis * use a real test against staging * keep sending chunks after a failure * fold batch tests into one --------- Co-authored-by: Lucain <lucain@huggingface.co> * [Download] Extend tmp .incomplete path on Windows when too long (#4978) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Fix HfFileSystem.get_file with a bare local filename (#4981) `os.path.dirname("file.txt")` is "", and `os.makedirs("")` raises FileNotFoundError. Fall back to the current directory, matching fsspec's base `get_file` and gcsfs (fsspec/gcsfs#618). Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Scope GITHUB_TOKEN permissions per job (#4982) A job with no `permissions:` block inherits whatever the repository hands out. Each block added here grants what that job's own steps need and nothing more. Co-authored-by: hf-security-analysis[bot] <265538906+hf-security-analysis[bot]@users.noreply.github.com> * Send PrivateLink config under privateService in create_inference_endpoint (#4966) * Send PrivateLink config under privateService in create_inference_endpoint * [Inference] Keep account_id compatible for endpoint creation * [Inference] Remove account_id compatibility test --------- Co-authored-by: Lucain Pouget <lucainp@gmail.com> --------- Signed-off-by: Sharvil Saxena <sharvil.saxena@gmail.com> Co-authored-by: Assaf Vayner <assaf@huggingface.co> Co-authored-by: Celina Hanouti <hanouticelina@gmail.com> Co-authored-by: Sreekant Baheti <60787859+Sreekant13@users.noreply.github.com> Co-authored-by: DltsumCtnori <lllalllbpear@gmail.com> Co-authored-by: dltsum <dltsum@users.noreply.github.com> Co-authored-by: Claude Code <noreply@anthropic.com> Co-authored-by: Daniel van Strien <davanstrien@users.noreply.github.com> Co-authored-by: Kayvan Zahiri <123409429+Kayvan-Zahiri@users.noreply.github.com> Co-authored-by: Sharvil Saxena <97365286+sharziki@users.noreply.github.com> Co-authored-by: shaun smith <1936278+evalstate@users.noreply.github.com> Co-authored-by: hf-security-analysis[bot] <265538906+hf-security-analysis[bot]@users.noreply.github.com> Co-authored-by: Corentin REGAL <corentin@huggingface.co> * [hfh 2.x] Migrate to httpx2 (#4921) * [httpx migration] Migrate to httpx2 * [Docs] Add HTTPX2 migration resources * [hfh 2.x] Fix HTTPX migration CI * [CLI] Regenerate CLI reference for v2 branch * [Core] Drop stale deprecated API exports * [Docs] Install httpx2 for documentation builds * Revert "[Docs] Install httpx2 for documentation builds" This reverts commit 4293e28. * fix(ci): harden workflow files flagged on #4994 (#4995) Co-authored-by: hf-security-analysis[bot] <265538906+hf-security-analysis[bot]@users.noreply.github.com> --------- Signed-off-by: Sharvil Saxena <sharvil.saxena@gmail.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Co-authored-by: Assaf Vayner <assaf@huggingface.co> Co-authored-by: Celina Hanouti <hanouticelina@gmail.com> Co-authored-by: Sreekant Baheti <60787859+Sreekant13@users.noreply.github.com> Co-authored-by: DltsumCtnori <lllalllbpear@gmail.com> Co-authored-by: dltsum <dltsum@users.noreply.github.com> Co-authored-by: Daniel van Strien <davanstrien@users.noreply.github.com> Co-authored-by: Kayvan Zahiri <123409429+Kayvan-Zahiri@users.noreply.github.com> Co-authored-by: Sharvil Saxena <97365286+sharziki@users.noreply.github.com> Co-authored-by: shaun smith <1936278+evalstate@users.noreply.github.com> Co-authored-by: hf-security-analysis[bot] <265538906+hf-security-analysis[bot]@users.noreply.github.com> Co-authored-by: Corentin REGAL <corentin@huggingface.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainintov2.0-dev-branchthrough Send PrivateLink config under privateService in create_inference_endpoint #4966, following the dedicated merge branch approach from [hfh 2.x] Merge main into v2.0 dev branch #4971.account_idargument fromHfApi.create_inference_endpointin 2.0. This is a breaking change: callers must useprivate_link_account_idtogether withprivate_link_regionto configure AWS PrivateLink.hf skills --claudeoption and take the newerHfFileSystem.get_filebare-filename fix frommainwhile resolving conflicts.For example, the 2.0 API now accepts:
Verified locally:
The
get_fileintegration test selection was stopped during Hub setup, before a result.Note
Medium Risk
Breaking Inference Endpoint kwargs affect callers still using
account_id, and bucket batch/copy now raise on partial server failures after applying successful operations.Overview
Merges recent
mainwork into the 2.x line, including a breaking change to Inference Endpoint creation and several reliability fixes.Inference Endpoints (breaking):
create_inference_endpointdrops the unusedaccount_idargument. AWS PrivateLink is configured withprivate_link_account_idand requiredprivate_link_region, sent asprivateServicein the API payload instead of top-levelaccountId.Bucket batches: Adds [
BucketBatchError] when the batch API reports failed operations (HTTP 200 partial failure or 422).batch_bucket_fileskeeps sending remaining chunks, then raises with aggregatedfailures;_batch_bucket_filesand bucket copy paths use the same handling. Docs note non-transactional behavior and the new exception.Downloads: Incomplete cache downloads on Windows use extended paths for unique temp files.
HfFileSystem.get_filehandles bare local filenames by creating the current directory when needed.CI: Multiple workflows set workflow-level
permissions: {}and grant minimal job-level permissions (mostlycontents: read).Reviewed by Cursor Bugbot for commit 994da87. Bugbot is set up for automated code reviews on this repo. Configure here.