Repository navigation
[Setup] Install hf-xet on Windows ARM64 - #5074
Merged
hanouticelina merged 1 commit intoOct 5, 2026
Merged
Conversation
Signed-off-by: Adrien Gallouët <angt@huggingface.co>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5074 +/- ##
==========================================
+ Coverage 75.00% 77.62% +2.62%
==========================================
Files 145 177 +32
Lines 13978 24787 +10809
==========================================
+ Hits 10484 19242 +8758
- Misses 3494 5545 +2051 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
angt
added a commit
to ggml-org/llama-install.sh
that referenced
this pull request
Oct 3, 2026
Waiting for huggingface/huggingface_hub#5074 Signed-off-by: Adrien Gallouët <angt@huggingface.co>
hanouticelina
approved these changes
Oct 5, 2026
hanouticelina
left a comment
Collaborator
There was a problem hiding this comment.
thanks for catching this!
Contributor
|
This PR has been shipped as part of the v2.2.0 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
platform.machine()asARM64, notarm64.platform_machine=='ARM64'to the marker so hf-xet is installed there too.Note
Low Risk
Single packaging marker change for an optional dependency; no runtime or security-sensitive logic.
Overview
Extends the hf-xet optional dependency marker in
setup.pyso the package is pulled in whenplatform.machine()reportsARM64, matching Windows on ARM64 (where Python uses that casing instead ofarm64).No other install logic or version pins change; only this environment marker is updated.
Reviewed by Cursor Bugbot for commit 36e127f. Bugbot is set up for automated code reviews on this repo. Configure here.