Skip to content

[Setup] Install hf-xet on Windows ARM64 - #5074

Merged
hanouticelina merged 1 commit into
huggingface:mainfrom
angt:setup-install-hf-xet-on-windows-arm64
Oct 5, 2026
Merged

hanouticelina merged 1 commit into
huggingface:mainfrom
angt:setup-install-hf-xet-on-windows-arm64

Conversation

@angt

@angt angt commented Oct 3, 2026 •

Copy link
Copy Markdown
Member

Summary

  • On Windows ARM64, Python reports platform.machine() as ARM64, not arm64.
  • This PR adds platform_machine=='ARM64' to the marker so hf-xet is installed there too.

Note

Low Risk
Single packaging marker change for an optional dependency; no runtime or security-sensitive logic.

Overview
Extends the hf-xet optional dependency marker in setup.py so the package is pulled in when platform.machine() reports ARM64, matching Windows on ARM64 (where Python uses that casing instead of arm64).

No other install logic or version pins change; only this environment marker is updated.

Reviewed by Cursor Bugbot for commit 36e127f. Bugbot is set up for automated code reviews on this repo. Configure here.

Signed-off-by: Adrien Gallouët <angt@huggingface.co>
@codecov

codecov Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.62%. Comparing base (1daa48b) to head (36e127f).
⚠️ Report is 761 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5074      +/-   ##
==========================================
+ Coverage   75.00%   77.62%   +2.62%     
==========================================
  Files         145      177      +32     
  Lines       13978    24787   +10809     
==========================================
+ Hits        10484    19242    +8758     
- Misses       3494     5545    +2051     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bot-ci-comment

bot-ci-comment Bot commented Oct 3, 2026

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

angt added a commit to ggml-org/llama-install.sh that referenced this pull request Oct 3, 2026
Waiting for huggingface/huggingface_hub#5074

Signed-off-by: Adrien Gallouët <angt@huggingface.co>

@julien-c julien-c left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@hanouticelina hanouticelina left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching this!

@hanouticelina
hanouticelina merged commit 42f9085 into huggingface:main Oct 5, 2026
25 of 27 checks passed
@huggingface-hub-bot

Copy link
Copy Markdown
Contributor

This PR has been shipped as part of the v2.2.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants