FIX Missing low_cpu_mem_usage argument#2156
Merged
BenjaminBossan merged 1 commit intohuggingface:mainfrom Oct 18, 2024
Merged
Conversation
The newly introduced low_cpu_mem_usage argument was not propagated to the add_adapter method of all PeftModel task types. This is now fixed and tests were added.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sayakpaul
approved these changes
Oct 17, 2024
Member
sayakpaul
left a comment
sayakpaul
left a comment
There was a problem hiding this comment.
Thanks! I like the modular design of the tests!
sirluk
pushed a commit
to sirluk/peft
that referenced
this pull request
Oct 19, 2024
The newly introduced low_cpu_mem_usage argument was not propagated to the add_adapter method of all PeftModel task types. This is now fixed and tests were added.
yaswanth19
pushed a commit
to yaswanth19/peft
that referenced
this pull request
Oct 20, 2024
The newly introduced low_cpu_mem_usage argument was not propagated to the add_adapter method of all PeftModel task types. This is now fixed and tests were added.
yaswanth19
pushed a commit
to yaswanth19/peft
that referenced
this pull request
Oct 20, 2024
The newly introduced low_cpu_mem_usage argument was not propagated to the add_adapter method of all PeftModel task types. This is now fixed and tests were added.
4 tasks
Guy-Bilitski
pushed a commit
to Guy-Bilitski/peft
that referenced
this pull request
May 13, 2025
The newly introduced low_cpu_mem_usage argument was not propagated to the add_adapter method of all PeftModel task types. This is now fixed and tests were added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The newly introduced
low_cpu_mem_usageargument was not propagated to theadd_adaptermethod of allPeftModeltask types. This is now fixed and tests were added.Tests were only added for LoRA to avoid running many relatively slow and redundant tests and because
low_cpu_mem_usageis not implemented for prompt learning models.