-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Fix #2477: Regression accessing modules_to_save
#2481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
githubnemo
merged 11 commits into
huggingface:main
from
githubnemo:issue/modules-to-save-regression
Apr 17, 2025
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ee6c5c6
Fix #2477: Regression accessing `modules_to_save`
a5267bf
Reviewer comments
c2cfb68
Remove presumably superflous code from inject_adapter
61d616a
Reviewer comments + extended tests
0b22b6e
Merge remote-tracking branch 'huggingface/main' into issue/modules-to…
3651f0e
Use a llama model for sequence classification
777448b
Check `modules_to_save` for prompt tuning methods
f903d78
Make style
39c7572
Don't assume config.modules_to_save to be iterable
b133062
Move `set_additional_trainable_modules`
b429434
Merge branch 'main' into issue/modules-to-save-regression
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Check
modules_to_save for prompt tuning methods
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.