TST: Refactor unittest to pytest style custom tests#2573
Merged
BenjaminBossan merged 1 commit intohuggingface:mainfrom Jun 6, 2025
Merged
Conversation
This is a follow up to huggingface#2462, huggingface#2478, and huggingface#2491. Finish the refactor from unittest-style tests to pytest-style tests to now also include the last big file to still use the old style, test_custom_models.py. This file was already mostly written with pytest in mind, so the changes were rather minimal. With this class refactored, we can finally remove ClassInstantier, which made understanding test parametrization much more difficult. There are still a few unittest.TestCase classes found throughout, but they are pretty isolated, so no big need to refactor them right now. Note that the test coverage is the same except for one difference. For some reason, I found that module level __getattr__ is no longer called when moving from unittest to pytest, such as here: https://github.com/huggingface/peft/blob/62c9cf30319ca219e1d6754626c17f510fc76441/src/peft/tuners/adalora/__init__.py#L32 This was pretty strange. I found out that these lines are invoked by usage of self.assertWarnsRegex, which is strange. The reason seems to be the unittest code here: https://github.com/python/cpython/blob/9258f3da9175134d03f2c8c7c7eed223802ad945/Lib/unittest/case.py#L296-L305 Therefore, I think it's safe to ignore this reduction in test coverage.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
efraimdahl
pushed a commit
to efraimdahl/peft
that referenced
this pull request
Jul 12, 2025
This is a follow up to huggingface#2462, huggingface#2478, and huggingface#2491. Finish the refactor from unittest-style tests to pytest-style tests to now also include the last big file to still use the old style, test_custom_models.py. This file was already mostly written with pytest in mind, so the changes were rather minimal. With this class refactored, we can finally remove ClassInstantier, which made understanding test parametrization much more difficult.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to #2462, #2478, and #2491.
Description
Finish the refactor from unittest-style tests to pytest-style tests to now also include the last big file to still use the old style,
test_custom_models.py. This file was already mostly written with pytest in mind, so the changes were rather minimal.With this class refactored, we can finally remove
ClassInstantier, which made understanding test parametrization much more difficult.There are still a few
unittest.TestCaseclasses found throughout, but they are pretty isolated, so no big need to refactor them right now.Test coverage
Note that the test coverage is the same except for one difference. For some reason, I found that module level
__getattr__is no longer called when moving from unittest to pytest, such as here:peft/src/peft/tuners/adalora/__init__.py
Line 32 in 62c9cf3
This was pretty strange. I found out that these lines are invoked by usage of
self.assertWarnsRegex, which is strange, as it appears unrelated. The reason seems to be the unittest code here:https://github.com/python/cpython/blob/9258f3da9175134d03f2c8c7c7eed223802ad945/Lib/unittest/case.py#L296-L305
Therefore, I think it's safe to ignore this reduction in test coverage.