Improve hf dense model throughput (no need actually) #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR needs the following #7 to function properly. Otherwise,
torch.compile+tensor parallelwill not workExpecting
There is no performance drop
Testing methodology
debug_local.sh)Results
v4.55.4python ./tooling_dev/test_hf_integration.py compare_throughput --torchtitan_dir v4.55.4/llama3/debugperf_large --hf_dir v4.55.4/meta-llama/Llama-3.2-1B/debugperf_large --hide_statuswith

torch.compile:python ./tooling_dev/test_hf_integration.py compare_throughput --torchtitan_dir v4.55.4_compile/llama3/debugperf_large --hf_dir v4.55.4_compile/meta-llama/Llama-3.2-1B/debugperf_large --hide_statusv4.57.1python ./tooling_dev/test_hf_integration.py compare_throughput --torchtitan_dir v4.57.1/llama3/debugperf_large --hf_dir v4.57.1/meta-llama/Llama-3.2-1B/debugperf_large --hide_statuswith
torch.compile:python ./tooling_dev/test_hf_integration.py compare_throughput --torchtitan_dir v.4.57.1_compile/llama3/debugperf_large --hf_dir v.4.57.1_compile/meta-llama/Llama-3.2-1B/debugperf_large --hide_status