Skip to content

[v4] suppress console.error while creating InferenceSession #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xenova merged 8 commits into from
Dec 9, 2025
Merged

[v4] suppress console.error while creating InferenceSession #1468

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1300ab0
suppress console.error while creating InferenceSession
nico-martin Nov 30, 2025
712230d
changed console suppress if not one of the misslieading errors
nico-martin Nov 30, 2025
ffe11a2
set default logSeverityLevel and also match the ONNX_WEB.env.logLevel
nico-martin Dec 2, 2025
9c41c3e
indentation
nico-martin Dec 2, 2025
0bf295f
small fix
nico-martin Dec 2, 2025
7d7b770
some clean-up
nico-martin Dec 2, 2025
6c0c0c0
Apply suggestions from code review
nico-martin Dec 3, 2025
dfaf024
added LOG_LEVELS to the top of the file
nico-martin Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/backends/onnx.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,21 @@ let webInitChain = Promise.resolve();
* @returns {Promise<import('onnxruntime-common').InferenceSession & { config: Object}>} The ONNX inference session.
*/
export async function createInferenceSession(buffer_or_path, session_options, session_config) {

/** @type {Array<'verbose' | 'info' | 'warning' | 'error' | 'fatal'>} */
const LOG_LEVELS = ['verbose', 'info', 'warning', 'error', 'fatal'];
/** @type 0|1|2|3|4 */
const logSeverityLevel =
typeof session_options.logSeverityLevel !== 'number' ||
session_options.logSeverityLevel < 0 ||
session_options.logSeverityLevel > 4
? 4
: session_options.logSeverityLevel;

ONNX_WEB.env.logLevel = LOG_LEVELS[logSeverityLevel];

session_options = { ...session_options, logSeverityLevel };
Copy link
Collaborator

@xenova xenova Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can move the ONNX_WEB.env.logLevel logic to happen during init (similar to how we set default WASM paths (as a good default).

This should hopefully minimize any session_options specific code a user would need to set.

Copy link
Collaborator Author

@nico-martin nico-martin Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think it makes sense to set the ONNX_WEB.env.logLevel here where I create a new session. Als a transformers.js user I dont really care if the log is a "onnxruntime session log" or a "onnxruntime general log". All I want to do is to create a pipeline and then be able to set the logLevel.
My solutions basically abstracts this decision away by only providing one setting and thats basically the settings that has always been available in the session_options (although very view people actually used that setting in the past I guess).

Copy link
Collaborator

@xenova xenova Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I agree with the point you made about a user not caring what kind of log is 👍

I guess one thing that this solution will prevent is a user modifying the logLevel themselves (which they can do with env.backends.onnx.env.logLevel = ...), because it will be overridden each time. Ideally, a default will be set once, and then a user can update these on a per-session (logSeverityLevel) or per-runtime (env.logLevel) basis.

Copy link
Collaborator

@xenova xenova Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe another option is to set a transformers.js-level logLevel, which would set both env and session-level


const load = () => InferenceSession.create(buffer_or_path, session_options);
const session = await (IS_WEB_ENV ? (webInitChain = webInitChain.then(load)) : load());
session.config = session_config;
Expand Down
2 changes: 2 additions & 0 deletions src/models.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,8 @@ async function getSession(pretrained_model_name_or_path, fileName, options, is_d

// Overwrite `executionProviders` if not specified
session_options.executionProviders ??= executionProviders;
// Set `logSeverityLevel` to 4 (fatal) if not specified
session_options.logSeverityLevel ??= 4;

// Overwrite `freeDimensionOverrides` if specified in config and not set in session options
const free_dimension_overrides = custom_config.free_dimension_overrides;
Expand Down
Loading