Allow lightness values without a % to parse#307
Merged
hykilpikonna merged 1 commit intohykilpikonna:masterfrom Jun 26, 2024
Merged
Allow lightness values without a % to parse#307hykilpikonna merged 1 commit intohykilpikonna:masterfrom
hykilpikonna merged 1 commit intohykilpikonna:masterfrom
Conversation
hykilpikonna
approved these changes
Jun 26, 2024
Owner
|
Nice addition |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As a hyfetch user, when configuring hyfetch on a new system, I often get to the lightness value and enter '65' without a %, leading to me having to retry. Because of this,I thought that instead changing the parsing to allow values like '65', '.65', or '65%' to parse correctly, as well as updating the parse error to reflect the changes
Screenshots
Additional context
Alternatively, updating the lightness message:
Which brightness level looks the best? (Default: 65% for dark mode)to mention the input options could also be good.