Skip to content

Add ERC-165 to IIBCModule #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 22, 2024
Merged

Add ERC-165 to IIBCModule #284

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9cd0189
implement ERC-165 for IBCModule
bluele Jul 11, 2024
3d0e4ac
check if a module supports expected interface
bluele Jul 11, 2024
b6b750b
fix tests for `bindPort`
bluele Jul 11, 2024
69fb44c
fix comments
bluele Jul 11, 2024
d69d2fa
add test checks if channel upgrade should be failed with non-upgradab…
bluele Jul 11, 2024
08cd74b
remove unused slither annotation
bluele Jul 12, 2024
f3d9b9e
fix to remove redundant mapping accesses
bluele Jul 13, 2024
402dedb
add ERC-165 support check to `bindPort`
bluele Jul 13, 2024
1828f70
rename unsafeLookupUpgradableModuleByPort to lookupUpgradableModuleBy…
bluele Jul 13, 2024
9438e52
update go bindings
bluele Jul 13, 2024
8d854ba
Merge remote-tracking branch 'origin/main' into module-erc165
bluele Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests for bindPort 
Signed-off-by: Jun Kimura <[email protected]>
  • Loading branch information
@bluele
bluele committed Jul 13, 2024
commit b6b750bf0ab9ded8a84518793bc6d5a770e644d5
2 changes: 1 addition & 1 deletion .gas-snapshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ TestICS03Version:testIsSupportedVersion() (gas: 7864)
TestICS03Version:testPickVersion() (gas: 25327)
TestICS03Version:testVerifyProposedVersion() (gas: 11777)
TestICS03Version:testVerifySupportedFeature() (gas: 4153)
TestICS04Handshake:testBindPort() (gas: 128408)
TestICS04Handshake:testBindPort() (gas: 137001)
TestICS04Handshake:testChanClose() (gas: 12938942)
TestICS04Handshake:testChanOpenAck() (gas: 3459492)
TestICS04Handshake:testChanOpenConfirm() (gas: 3770761)
Expand Down
12 changes: 10 additions & 2 deletions tests/foundry/src/ICS04Handshake.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,22 @@ contract TestICS04Handshake is ICS03TestHelper, ICS04HandshakeMockClientTestHelp
}

function testBindPort() public {
assertNotEq(address(handler.getIBCModuleByPort("portidone")), address(0));
vm.expectRevert();
handler.getIBCModuleByPort("portidtwo");

// must be failed if the port is already binded
vm.expectRevert();
handler.bindPort("portidone", mockApp);
// must be failed if the module does not support IIBCModule
vm.expectRevert();
handler.bindPort("portidone", IIBCModule(address(0x01)));
handler.bindPort("portidtwo", IIBCModule(address(0x01)));
// must be failed if the port is empty
vm.expectRevert();
handler.bindPort("", IIBCModule(address(0x01)));
// must be failed if the module address is empty
vm.expectRevert();
handler.bindPort("portidone", IIBCModule(address(0)));
handler.bindPort("portidtwo", IIBCModule(address(0)));
}

function testChanOpenInit() public {
Expand Down