Skip to content

IBC-3: fix to ensure connection.state is OPEN in channelOpenAck() #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2024
+4 −0
Merged

IBC-3: fix to ensure connection.state is OPEN in channelOpenAck() #304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions contracts/core/04-channel/IBCChannelHandshake.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ contract IBCChannelHandshake is IBCModuleManager, IIBCChannelHandshake, IIBCChan
if (msg_.channel.connection_hops.length != 1) {
revert IBCChannelInvalidConnectionHopsLength(msg_.channel.connection_hops.length);
}
// optimistic channel handshakes are allowed, so we can skip checking if the connection state is OPEN here.
ConnectionEnd.Data storage connection = getConnectionStorage()[msg_.channel.connection_hops[0]].connection;
if (connection.versions.length != 1) {
revert IBCChannelConnectionMultipleVersionsFound(
Expand Down Expand Up @@ -164,6 +165,9 @@ contract IBCChannelHandshake is IBCModuleManager, IIBCChannelHandshake, IIBCChan
revert IBCChannelUnexpectedChannelState(channel.state);
}
ConnectionEnd.Data storage connection = getConnectionStorage()[channel.connection_hops[0]].connection;
if (connection.state != ConnectionEnd.State.STATE_OPEN) {
revert IBCChannelConnectionNotOpened(channel.connection_hops[0]);
}
Channel.Data memory expectedChannel = Channel.Data({
state: Channel.State.STATE_TRYOPEN,
ordering: channel.ordering,
Expand Down