Audit-202409 #306
Merged
Audit-202409 #306
+960
−349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jun Kimura <[email protected]>
IBC-2: Fix to update channel commitment in `timeoutPacket()` Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
IBC-3: fix to ensure `connection.state` is `OPEN` in `channelOpenAck()` Signed-off-by: Jun Kimura <[email protected]>
…to the height matches the previous one in `updateClientCommitments()` Signed-off-by: Jun Kimura <[email protected]>
IBC-4: fix to ensure the commitment of consensus state corresponding to the height matches the previous one in `updateClientCommitments()` Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
IBC-5: delete packet commitment in `timeoutOnClose()` Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
…lose()` Signed-off-by: Jun Kimura <[email protected]>
IBC-7: fix to remove state check in `timeoutPacket()` and `timeoutOnClose()` Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
…d in `recvPacket()` and `timeoutPacket()` Signed-off-by: Jun Kimura <[email protected]>
IBC-1: Add counterparty upgrade timeout check to `acknowledgePacket()` and `timeoutPacket()` Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
IBC-8: Fix missing checks on `revision_number` Signed-off-by: Jun Kimura <[email protected]>
IBC-14: clarify which sequence commitments are stored Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
IBC-11: fix `clientType` and `clientId` validations Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
IBC-12: Improve docs for `routeUpdateClient()` Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
…ler.constructor()` Signed-off-by: Jun Kimura <[email protected]>
…OnClose()` Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
Fix audit suggestions Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
IBC-15: Deviations from IBC specs Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
IBC-6: add module developer warning to doc of `sendPacket()` Signed-off-by: Jun Kimura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.