Skip to content

Fix audit suggestions #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 4, 2024
Merged

Fix audit suggestions #314

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6ace215
S7: improve validation for `Version` in `connectionOpenInit()`
bluele Nov 25, 2024
718fe09
S8: remove redundant ERC165 checks
bluele Nov 25, 2024
1a8e20d
S1: improve comments for connection
bluele Nov 26, 2024
3c82e7a
S6: fix incorrect comment for `channelOpenConfirm()`
bluele Nov 26, 2024
c690dde
S4: fix to add address validation for `IBCClientConnectionChannelHand…
bluele Nov 26, 2024
11c488e
S3: separate `TimeoutPacket` event for `timeoutPacket()` and `timeout…
bluele Nov 26, 2024
15ecd73
S9: add some fields to `IBCChannelUnexpectedNextSequenceRecv` error
bluele Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
S4: fix to add address validation for `IBCClientConnectionChannelHand… 
…ler.constructor()`

Signed-off-by: Jun Kimura <[email protected]>
  • Loading branch information
@bluele
bluele committed Dec 4, 2024
commit c690dde14cea373d4f9a5d448d41e533743143ae
8 changes: 8 additions & 0 deletions contracts/core/25-handler/IBCClientConnectionChannelHandler.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,14 @@ abstract contract IBCClientConnectionChannelHandler is
IIBCChannelUpgradeInitTryAck ibcChannelUpgradeInitTryAck_,
IIBCChannelUpgradeConfirmOpenTimeoutCancel ibcChannelUpgradeConfirmOpenTimeoutCancel_
) {
if (
address(ibcClient_) == address(0) || address(ibcConnection_) == address(0)
|| address(ibcChannelHandshake_) == address(0) || address(ibcChannelPacketSendRecv_) == address(0)
|| address(ibcChannelPacketTimeout_) == address(0) || address(ibcChannelUpgradeInitTryAck_) == address(0)
|| address(ibcChannelUpgradeConfirmOpenTimeoutCancel_) == address(0)
) {
revert("invalid address");
}
ibcClient = address(ibcClient_);
ibcConnection = address(ibcConnection_);
ibcChannelHandshake = address(ibcChannelHandshake_);
Expand Down