Skip to content

Closes #274: Adding FFI function for types bool, float, String, vecbytes #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Closes #274: Adding FFI function for types bool, float, String, vecbytes #903

wants to merge 14 commits into from

Conversation

vshailesh
Copy link
Contributor

@vshailesh vshailesh commented Sep 22, 2025 •
edited
Loading

Added functions for #274

@vshailesh
Closes hyperlight-dev#274: Adding FFI function for types bool, float,…
a868f66 
… String, vecbytes

Signed-off-by: Shailesh Vashishth <[email protected]>
@ludfjig ludfjig added the kind/enhancement For PRs adding features, improving functionality, docs, tests, etc. label Sep 22, 2025
@ludfjig
Copy link
Contributor

ludfjig commented Sep 22, 2025

Thanks for this. Would you mind adding a corresponding test for these types in simpleguest.c ( a guest function that calls a host function) and call them from either integration_test.rs or sandbox_host_test.rs or initialized_multi_use.rs?

@vshailesh
Copy link
Contributor Author

I will add tests

vshailesh and others added 13 commits September 23, 2025 13:08
@vshailesh
import fixes for hyperlight-dev#274
4034bab 
Signed-off-by: Shailesh Vashishth <[email protected]>
@vshailesh
change of function name
78cca4b 
Signed-off-by: Shailesh Vashishth <[email protected]>
@vshailesh
format fixes
8a16031 
Signed-off-by: Shailesh Vashishth <[email protected]>
@dependabot @vshailesh
Bump libc from 0.2.175 to 0.2.176 (hyperlight-dev#910)
6713bfd 
Bumps [libc](https://github.com/rust-lang/libc) from 0.2.175 to 0.2.176.
- [Release notes](https://github.com/rust-lang/libc/releases)
- [Changelog](https://github.com/rust-lang/libc/blob/0.2.176/CHANGELOG.md)
- [Commits](rust-lang/libc@0.2.175...0.2.176)

---
updated-dependencies:
- dependency-name: libc
  dependency-version: 0.2.176
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @vshailesh
Bump tempfile from 3.22.0 to 3.23.0 (hyperlight-dev#909)
42d5196 
Bumps [tempfile](https://github.com/Stebalien/tempfile) from 3.22.0 to 3.23.0.
- [Changelog](https://github.com/Stebalien/tempfile/blob/master/CHANGELOG.md)
- [Commits](Stebalien/tempfile@v3.22.0...v3.23.0)

---
updated-dependencies:
- dependency-name: tempfile
  dependency-version: 3.23.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @vshailesh
Bump windows from 0.62.0 to 0.62.1 (hyperlight-dev#916)
0336c2c 
Bumps [windows](https://github.com/microsoft/windows-rs) from 0.62.0 to 0.62.1.
- [Release notes](https://github.com/microsoft/windows-rs/releases)
- [Commits](https://github.com/microsoft/windows-rs/commits)

---
updated-dependencies:
- dependency-name: windows
  dependency-version: 0.62.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @vshailesh
Bump windows-sys from 0.61.0 to 0.61.1 (hyperlight-dev#914)
8729967 
Bumps [windows-sys](https://github.com/microsoft/windows-rs) from 0.61.0 to 0.61.1.
- [Release notes](https://github.com/microsoft/windows-rs/releases)
- [Commits](https://github.com/microsoft/windows-rs/commits)

---
updated-dependencies:
- dependency-name: windows-sys
  dependency-version: 0.61.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @vshailesh
Bump flatbuffers from 25.2.10 to 25.9.23 (hyperlight-dev#911)
2d24b1f 
Bumps [flatbuffers](https://github.com/google/flatbuffers) from 25.2.10 to 25.9.23.
- [Release notes](https://github.com/google/flatbuffers/releases)
- [Changelog](https://github.com/google/flatbuffers/blob/master/CHANGELOG.md)
- [Commits](google/flatbuffers@v25.2.10...v25.9.23)

---
updated-dependencies:
- dependency-name: flatbuffers
  dependency-version: 25.9.23
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @vshailesh
Bump opentelemetry-semantic-conventions from 0.30.0 to 0.31.0 (hyperl…
ceb86ca 
…ight-dev#915)

Bumps [opentelemetry-semantic-conventions](https://github.com/open-telemetry/opentelemetry-rust) from 0.30.0 to 0.31.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-rust/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-rust/blob/main/docs/release_0.30.md)
- [Commits](https://github.com/open-telemetry/opentelemetry-rust/commits)

---
updated-dependencies:
- dependency-name: opentelemetry-semantic-conventions
  dependency-version: 0.31.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @vshailesh
Bump crate-ci/typos from 1.36.2 to 1.36.3 (hyperlight-dev#912)
3534df1 
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.36.2 to 1.36.3.
- [Release notes](https://github.com/crate-ci/typos/releases)
- [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md)
- [Commits](crate-ci/typos@v1.36.2...v1.36.3)

---
updated-dependencies:
- dependency-name: crate-ci/typos
  dependency-version: 1.36.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @vshailesh
Bump windows-version from 0.1.5 to 0.1.6 (hyperlight-dev#918)
b5f1c60 
Bumps [windows-version](https://github.com/microsoft/windows-rs) from 0.1.5 to 0.1.6.
- [Release notes](https://github.com/microsoft/windows-rs/releases)
- [Commits](https://github.com/microsoft/windows-rs/commits)

---
updated-dependencies:
- dependency-name: windows-version
  dependency-version: 0.1.6
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @vshailesh
Bump serde from 1.0.226 to 1.0.227 (hyperlight-dev#917)
7d89c8a 
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.226 to 1.0.227.
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.226...v1.0.227)

---
updated-dependencies:
- dependency-name: serde
  dependency-version: 1.0.227
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@vshailesh
Added Test for issue hyperlight-dev#274
39f706a 
Signed-off-by: Shailesh Vashishth <[email protected]>
@ludfjig
Copy link
Contributor

ludfjig commented Sep 29, 2025

Would you mind adding test for each of the new types, like you've done for bool? Also, a StackOverflow error is unexpected here, and I think you're forgetting to register a hostfunction on the sandbox before calling evolve on it. See here for an example: https://github.com/ludfjig/hyperlight/blob/ae355d7e33a53c5d7e224edf2428e8251a10a62e/src/hyperlight_host/src/sandbox/initialized_multi_use.rs#L573

jsturtevant
jsturtevant reviewed Sep 29, 2025
View reviewed changes
src/tests/c_guests/c_simpleguest/main.c
}


bool host_returns_bool_value(const char *from_host) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not taking a string as parameter might make this simpler to test

jsturtevant
jsturtevant reviewed Sep 29, 2025
View reviewed changes
src/tests/c_guests/c_simpleguest/main.c
hl_register_function_definition("24K_in_8K_out", twenty_four_k_in_eight_k_out, 1, (hl_ParameterType[]){hl_ParameterType_VecBytes}, hl_ReturnType_VecBytes);
// HYPERLIGHT_REGISTER_FUNCTION macro does not work for functions that return VecBytes,
// so we use hl_register_function_definition directly
hl_register_function_definition("24K_in_8K_out", twenty_four_k_in_eight_k_out, 1, (hl_ParameterType[]){hl_ParameterType_VecBytes}, hl_ReturnType_VecBytes);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a copy paste of the function above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsturtevant jsturtevant jsturtevant left review comments

@danbugs danbugs Awaiting requested review from danbugs danbugs is a code owner

@ludfjig ludfjig Awaiting requested review from ludfjig ludfjig is a code owner

@dblnz dblnz Awaiting requested review from dblnz dblnz is a code owner

@devigned devigned Awaiting requested review from devigned devigned is a code owner

@syntactically syntactically Awaiting requested review from syntactically syntactically is a code owner

@marosset marosset Awaiting requested review from marosset marosset is a code owner

@jprendes jprendes Awaiting requested review from jprendes jprendes is a code owner

@simongdavies simongdavies Awaiting requested review from simongdavies simongdavies is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
kind/enhancement For PRs adding features, improving functionality, docs, tests, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vshailesh @ludfjig @jsturtevant