make ui compile properly cross-platform again #721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see fix implemented here, discussed at: npm/cli#4828 (comment) soon there will be a PR to address so we may be able to remove these optional dependencies once this PR is merged: npm/cli#8177
Contributor
|
Well that's completely insane. I'm sorry that I probably contributed to messing this up. |
Member
Author
|
Nope, not at all; I think it was just that rollup 4.35 worked and then 4.37 didn't, so have to force it with the optionalDeps (till npm devs can be bothered to fix it) |
Contributor
|
@nick1udwig didn't realize I was pushing to this branch - apologies. Will PR next one. |
Contributor
|
yes, 1.2.1 works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Cross-platform builds don't work again.
Solution
see fix implemented here, discussed at:
npm/cli#4828 (comment)
Testing
It work? @Hallmane
Docs Update
None
Notes
soon there will be a PR to address so we may be able to remove these optional dependencies once this PR is merged: npm/cli#8177