Skip to content

Conversation

@0x70b1a5
Copy link
Contributor

@0x70b1a5 0x70b1a5 commented Mar 28, 2025

Problem

Lightmode links are messed up; appstore needs some "mobility"

Solution

Continue to take the axe to all manner of inutile Cascading Style Sheet rules

Testing

Open the app store in lightmode, 
click around, 
resize the browser, etc.... 
same on homepage.

Docs Update

Nope

@0x70b1a5 0x70b1a5 changed the base branch from main to develop March 28, 2025 18:14
@nick1udwig
Copy link
Member

nick1udwig commented Mar 28, 2025

Looks really good. Found two issues:

  1. color issue on registration flow: the progress bar thing on light mode:

Screenshot from 2025-03-28 16-00-53

  1. default icon in app store (i.e. if no icon supplied) is left-justified in mobile view:

image

After fixing those, merge away! Really nice work

We'll have to revisit mobile App Store, but I think not for this PR. Not sure if its work for us or for a designer, but it should look a lot more like the "state of the art" app stores (iOS and Google Play):

image

Copy link
Member

@nick1udwig nick1udwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make requested changes, then merge when ready

@0x70b1a5 0x70b1a5 merged commit 662b6bd into develop Mar 31, 2025
1 check passed
@0x70b1a5 0x70b1a5 deleted the tm/lightmode-and-appstore branch March 31, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants