Skip to content

Conversation

@nick1udwig
Copy link
Member

Problem

Secure subdomain can be circumvented by the user manually navigating to that subdomain and then entering another apps endpoint. E.g., imagine there is a good:good:foo.os app and a evil:evil:bar.os app. good has a secure subdomain. Then the user can manually navigate to

good-foo-os.example.com/evil:evil:bar.os

and then evil can access goods api.

This exposes users to accidents and malicious apps/users ("just navigate to this link and it'll work").

Solution

Don't allow secure subdomains to be used for any but their matching endpoint.

Testing

test-secure-subdomain.tar.gz

good and evil, above, both serve uis. Try to access goods API via evil. On main it works; here it does not.

Docs Update

None

Notes

None

nick1udwig and others added 2 commits June 18, 2025 20:36
stop user from manually navigating to a subdomain that
can then be used to access a protected api
@nick1udwig nick1udwig marked this pull request as ready for review June 19, 2025 18:51
@nick1udwig nick1udwig merged commit 2483921 into develop Jun 19, 2025
@nick1udwig nick1udwig deleted the hf/improve-secure-subdomains branch June 19, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants