secure subdomains: increase security #755
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Secure subdomain can be circumvented by the user manually navigating to that subdomain and then entering another apps endpoint. E.g., imagine there is a
good:good:foo.osapp and aevil:evil:bar.osapp.goodhas a secure subdomain. Then the user can manually navigate toand then
evilcan accessgoods api.This exposes users to accidents and malicious apps/users ("just navigate to this link and it'll work").
Solution
Don't allow secure subdomains to be used for any but their matching endpoint.
Testing
test-secure-subdomain.tar.gz
goodandevil, above, both serve uis. Try to accessgoods API via evil. On main it works; here it does not.Docs Update
None
Notes
None