Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
is_localis not a robust way to determine that an http request is actually local. E.g., a node behind a reverse proxy will believe all http requests it receives are local.Solution
is_localhandling by default. Enable it with the commandline flagexpose-localexpose-locald, check forx-forwarded-type headers that reverse proxies commonly put on requests. Caddy puts these headers by default; nginx does not; apache may or may not.Testing
Docs Update
TODO
Notes
None