register and appstore ui #772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick1udwig
requested changes
Jul 2, 2025
Member
nick1udwig
left a comment
nick1udwig
left a comment
There was a problem hiding this comment.
Some visual issues with app store:
- the "flashy" part of text input selection doesn't display with proper size on "Search apps..." (mobile & desktop)
- the notifications popover can go offscreen (mobile)
- My Apps has some weird text wrapping/overlapping going on (mobile)
- My apps -> Retry has some issues in terms of spacing text, buttons, etc
- My apps -> Advanced has some text overlapping (mobile)
Visual nit with login
- The Hyperware "H" logo bounces when going from entering password to waiting for login to complete. Ideally it would not move vertically between these screens
Register UI
Looks great. One nit:
- For thing windows, the "Direct node" checkbox renders weirdly
Contributor
Author
|
@nick1udwig Addressed issues. Please examine and merge if acceptable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a lot of groundwork related to dark/light mode display, logos and fonts, removing Uno and restoring Tailwind in the register / appstore / settings pages, and simplifying a lot of unnecessary CSS.
The UI continues to improve. It's not identical to the Figma yet, but with this PR I can rest easy knowing that the basics are covered.
Testing: