Skip to content

Conversation

@nick1udwig
Copy link
Member

Problem

resolves #806

Solution

Don't allow overflow/underflow

Testing

Try making terminal "too small"

Docs Update

None

Notes

None

@nick1udwig nick1udwig requested a review from 0x70b1a5 August 6, 2025 18:36
@0x70b1a5
Copy link
Contributor

0x70b1a5 commented Aug 7, 2025

still happens

thread 'main' panicked at hyperdrive/src/terminal/mod.rs:74:17:
           attempt to subtract with overflow
           note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

just run in cursor terminal and click the split terminal button until you have a bunch open

@nick1udwig
Copy link
Member Author

Aha, getting closer: that's a different line. I've replaced all of those similar subtractions with saturating_subs; seems to work now:

image

@nick1udwig nick1udwig merged commit 6b8291a into develop Aug 7, 2025
@nick1udwig nick1udwig deleted the hf/fix-terminal-resize-crash branch August 7, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants